From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758091Ab1CCDNN (ORCPT ); Wed, 2 Mar 2011 22:13:13 -0500 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:34700 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757230Ab1CCDNL (ORCPT ); Wed, 2 Mar 2011 22:13:11 -0500 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: Oleg Nesterov Subject: Re: [PATCH v3 3/4] exec: unify do_execve/compat_do_execve code Cc: kosaki.motohiro@jp.fujitsu.com, Linus Torvalds , Andrew Morton , LKML , linux-mm , pageexec@freemail.hu, Solar Designer , Eugene Teo , Brad Spengler , Roland McGrath , Milton Miller In-Reply-To: <20110302162753.GD26810@redhat.com> References: <20110302162650.GA26810@redhat.com> <20110302162753.GD26810@redhat.com> Message-Id: <20110303120915.B951.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50.07 [ja] Date: Thu, 3 Mar 2011 12:13:08 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -1510,11 +1528,27 @@ int do_execve(const char *filename, > const char __user *const __user *__envp, > struct pt_regs *regs) > { > - struct conditional_ptr argv = { .native = __argv }; > - struct conditional_ptr envp = { .native = __envp }; > + struct conditional_ptr argv = { .ptr.native = __argv }; > + struct conditional_ptr envp = { .ptr.native = __envp }; > return do_execve_common(filename, argv, envp, regs); > } > > +#ifdef CONFIG_COMPAT > +int compat_do_execve(char *filename, > + compat_uptr_t __user *__argv, > + compat_uptr_t __user *__envp, > + struct pt_regs *regs) > +{ > + struct conditional_ptr argv = { > + .is_compat = true, .ptr.compat = __argv, > + }; Please don't mind to compress a line. struct conditional_ptr argv = { .is_compat = true, .ptr.compat = __argv, }; is more good readability. Other parts looks very good to me. Reviewed-by: KOSAKI Motohiro From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id DC7C18D0039 for ; Wed, 2 Mar 2011 22:13:12 -0500 (EST) Received: from m3.gw.fujitsu.co.jp (unknown [10.0.50.73]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id D0A343EE0BD for ; Thu, 3 Mar 2011 12:13:09 +0900 (JST) Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id B3D7645DE60 for ; Thu, 3 Mar 2011 12:13:09 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 7DBFA45DE57 for ; Thu, 3 Mar 2011 12:13:09 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 6D572E18001 for ; Thu, 3 Mar 2011 12:13:09 +0900 (JST) Received: from m105.s.css.fujitsu.com (m105.s.css.fujitsu.com [10.249.87.105]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 347BCE08002 for ; Thu, 3 Mar 2011 12:13:09 +0900 (JST) From: KOSAKI Motohiro Subject: Re: [PATCH v3 3/4] exec: unify do_execve/compat_do_execve code In-Reply-To: <20110302162753.GD26810@redhat.com> References: <20110302162650.GA26810@redhat.com> <20110302162753.GD26810@redhat.com> Message-Id: <20110303120915.B951.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Date: Thu, 3 Mar 2011 12:13:08 +0900 (JST) Sender: owner-linux-mm@kvack.org List-ID: To: Oleg Nesterov Cc: kosaki.motohiro@jp.fujitsu.com, Linus Torvalds , Andrew Morton , LKML , linux-mm , pageexec@freemail.hu, Solar Designer , Eugene Teo , Brad Spengler , Roland McGrath , Milton Miller > @@ -1510,11 +1528,27 @@ int do_execve(const char *filename, > const char __user *const __user *__envp, > struct pt_regs *regs) > { > - struct conditional_ptr argv = { .native = __argv }; > - struct conditional_ptr envp = { .native = __envp }; > + struct conditional_ptr argv = { .ptr.native = __argv }; > + struct conditional_ptr envp = { .ptr.native = __envp }; > return do_execve_common(filename, argv, envp, regs); > } > > +#ifdef CONFIG_COMPAT > +int compat_do_execve(char *filename, > + compat_uptr_t __user *__argv, > + compat_uptr_t __user *__envp, > + struct pt_regs *regs) > +{ > + struct conditional_ptr argv = { > + .is_compat = true, .ptr.compat = __argv, > + }; Please don't mind to compress a line. struct conditional_ptr argv = { .is_compat = true, .ptr.compat = __argv, }; is more good readability. Other parts looks very good to me. Reviewed-by: KOSAKI Motohiro -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org