Re: linux-next: manual merge of the net tree with the net-current tree

From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "Dmitry Kravkov" <dmitry@broadcom.com>
Cc: "David Miller" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Eilon Greenstein" <eilong@broadcom.com>,
	"Vladislav Zolotarov" <vladz@broadcom.com>
Subject: Re: linux-next: manual merge of the net tree with the net-current tree
Date: Wed, 9 Mar 2011 11:11:13 +1100	[thread overview]
Message-ID: <20110309111113.883972ba.sfr@canb.auug.org.au> (raw)
In-Reply-To: <1299577473.17233.41.camel@lb-tlvb-dmitry>

[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]

Hi Dmitry,

On Tue, 8 Mar 2011 11:44:33 +0200 "Dmitry Kravkov" <dmitry@broadcom.com> wrote:
>
> You are correct it's just an addition and it does not really matter
> where to do this. But the merge pushed new code in the middle
> of MAC configuration between MAC and multicast list.
> It's clearer to put it at the end of MAC/ML/UL block:
> ---
>  drivers/net/bnx2x/bnx2x_cmn.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/bnx2x/bnx2x_cmn.c b/drivers/net/bnx2x/bnx2x_cmn.c
> index b01b622..9e37675 100644
> --- a/drivers/net/bnx2x/bnx2x_cmn.c
> +++ b/drivers/net/bnx2x/bnx2x_cmn.c
> @@ -1498,6 +1498,11 @@ int bnx2x_nic_load(struct bnx2x *bp, int load_mode)
>  	/* Clear UC lists configuration */
>  	bnx2x_invalidate_uc_list(bp);
>  
> +	if (bp->pending_max) {
> +		bnx2x_update_max_mf_config(bp, bp->pending_max);
> +		bp->pending_max = 0;
> +	}
> +
>  	if (bp->port.pmf)
>  		bnx2x_initial_phy_init(bp, load_mode);

OK, thanks.  I have changed the conflict resolution to do that.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]