All of
 help / color / mirror / Atom feed
From: Chuck Lever <>
Subject: [PATCH] NFS: Revert NFSROOT default mount options
Date: Fri, 25 Mar 2011 10:23:40 -0400	[thread overview]
Message-ID: <> (raw)

Marek Belisko <> reports that recent attempts
to fix regressions in NFSROOT have broken his configuration:

> After update from 2.6.38-rc8 to 2.6.38 is mounting rootfs over nfs not possible.
> Log:
> VFS: Mounted root (nfs filesystem) on device 0:14.
> Freeing init memory: 132K
> nfs: server not responding, still trying
> nfs: server not responding, still trying
> This is never ending. I make short bisect (not too much commits
> between versions)
> and bad commit was reported: 53d4737580535e073963b91ce87d4216e434fab5
> NFS: NFSROOT should default to "proto=udp"
> I've tested on mini2440 board (DM9000, static IP).
> Is there some missing option or something else to be checked?

An examination of a network trace captured during the failure shows
that the mount is actually succeeding, but that the client is not
seeing READ replies larger than 16KB.

Last fall we removed the ad hoc mount option parser in fs/nfs/nfsroot.c
in favor of using the main parser in fs/nfs/super.c (see commit
56463e50 "NFS: Use super.c for NFSROOT mount option parsing").  That
commit changed the default NFSROOT mount options to be the same as
those employed by user space mounts.  As it turns out, that change is
not tolerated by many embedded systems.

Subsequently, commit 53d47375 introduced a clean way to specify
default mount options for NFSROOT, so we can restore the traditional
defaults for NFSROOT easily now:


This should revert the changed default NFSROOT mount options
introduced with commit 56463e50.

Signed-off-by: Chuck Lever <>


Please test this, as I no longer have an NFSROOT rig here.

Can some responsible maintainer type see that this gets into
linux-next quickly for broader testing?

 fs/nfs/nfsroot.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/nfs/nfsroot.c b/fs/nfs/nfsroot.c
index c541093..c4744e1 100644
--- a/fs/nfs/nfsroot.c
+++ b/fs/nfs/nfsroot.c
@@ -87,7 +87,7 @@
 #define NFS_ROOT		"/tftpboot/%s"
 /* Default NFSROOT mount options. */
-#define NFS_DEF_OPTIONS		"udp"
+#define NFS_DEF_OPTIONS		"vers=2,udp,rsize=4096,wsize=4096"
 /* Parameters passed from the kernel command line */
 static char nfs_root_parms[256] __initdata = "";

             reply	other threads:[~2011-03-25 14:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-25 14:23 Chuck Lever [this message]
2011-03-28  5:09 ` [PATCH] NFS: Revert NFSROOT default mount options Belisko Marek
2011-03-28 13:15   ` Chuck Lever
2011-03-28 14:25 Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.