All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Ralf Ramsauer <ralf.ramsauer@googlemail.com>,
	Alexander Graf <agraf@suse.de>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] hw: improve multiboot module loading
Date: Thu, 7 Apr 2011 20:13:33 +0200	[thread overview]
Message-ID: <20110407181333.GD5240@os.inf.tu-dresden.de> (raw)
In-Reply-To: <BANLkTiknT=AR4PNaQsEj50PM-KO9AmO=Mw@mail.gmail.com>


On Thu Apr 07, 2011 at 14:52:34 +0100, Stefan Hajnoczi wrote:
> On Thu, Apr 7, 2011 at 1:56 PM, Ralf Ramsauer
> <ralf.ramsauer@googlemail.com> wrote:
> > On 07.04.2011, at 14:48, Stefan Hajnoczi wrote:
> >
> >> Out of curiousity, why are you trying to kill spaces at all?
> >>
> >> Why not just use a correct command-line to invoke QEMU?
> >>
> >> Stefan
> >
> > Well it took me 2 days to find out why -initrd "module1, module2" didn't work. If there's a space after the comma you'll always
> > get the error message "Failed to get  image size".
> 
> How about improving the error message?

I'll send a patch shortly fixing the message.
 
> > And if you want to pass a comma in a multiboot argument you've no way to do this.
> > So -initrd"module1 settings=use_foo,use_bar" won't work!
> 
> >From what I can tell your patch does not change this.

It should be possible to put commas on the mb command line.
Do we want to escape commas?



Adam
-- 
Adam                 adam@os.inf.tu-dresden.de
  Lackorzynski         http://os.inf.tu-dresden.de/~adam/

  reply	other threads:[~2011-04-07 18:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-07  0:19 [Qemu-devel] [PATCH] hw: improve multiboot module loading ralf
2011-04-07  0:31 ` Alexander Graf
2011-04-07  5:56   ` Ralf Ramsauer
2011-04-07  8:38     ` Alexander Graf
2011-04-07 12:07       ` Ralf Ramsauer
2011-04-07 12:15         ` Alexander Graf
2011-04-07 12:24         ` Ralf Ramsauer
2011-04-07 12:48           ` Stefan Hajnoczi
2011-04-07 12:56             ` Ralf Ramsauer
2011-04-07 13:52               ` Stefan Hajnoczi
2011-04-07 18:13                 ` Adam Lackorzynski [this message]
2011-04-07  2:00 ` Brad Hards
2011-04-07  8:43 ` Stefan Hajnoczi
2011-04-07 10:18   ` Ralf Ramsauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110407181333.GD5240@os.inf.tu-dresden.de \
    --to=adam@os.inf.tu-dresden.de \
    --cc=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=ralf.ramsauer@googlemail.com \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.