All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yang Ruirui <ruirui.r.yang@tieto.com>
To: <tytso@mit.edu>, <linux-ext4@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH] ext4: release page cache in ext4_mb_load_buddy error path
Date: Thu, 14 Apr 2011 14:44:41 +0800	[thread overview]
Message-ID: <20110414064441.GA3499@darkstar> (raw)

Add missing page_cache_release in the error path of ext4_mb_load_buddy

Signed-off-by: Yang Ruirui <ruirui.r.yang@tieto.com>
---
 fs/ext4/mballoc.c |    2 ++
 1 file changed, 2 insertions(+)

--- linux-2.6.orig/fs/ext4/mballoc.c	2011-04-14 14:04:48.000000000 +0800
+++ linux-2.6/fs/ext4/mballoc.c	2011-04-14 14:33:28.702958245 +0800
@@ -1273,6 +1273,8 @@ repeat_load_buddy:
 	return 0;
 
 err:
+	if (page)
+		page_cache_release(page);
 	if (e4b->bd_bitmap_page)
 		page_cache_release(e4b->bd_bitmap_page);
 	if (e4b->bd_buddy_page)

             reply	other threads:[~2011-04-14  6:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-14  6:44 Yang Ruirui [this message]
2011-04-14  7:01 ` [PATCH] ext4: release page cache in ext4_mb_load_buddy error path Amir Goldstein
2011-04-14  7:29   ` Yang Rui Rui
2011-04-14  7:46     ` Amir Goldstein
2011-04-14  8:28       ` Yang Rui Rui
2011-04-16 23:07 ` Ted Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110414064441.GA3499@darkstar \
    --to=ruirui.r.yang@tieto.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.