From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 08/13] drm/i915: Pin after setting to the display plane Date: Thu, 14 Apr 2011 19:34:17 +0200 Message-ID: <20110414173416.GE3408@viiv.ffwll.ch> References: <1302771827-26112-1-git-send-email-chris@chris-wilson.co.uk> <1302771827-26112-9-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wy0-f177.google.com (mail-wy0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F60C9E79E for ; Thu, 14 Apr 2011 10:34:50 -0700 (PDT) Received: by wyb28 with SMTP id 28so2043324wyb.36 for ; Thu, 14 Apr 2011 10:34:49 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1302771827-26112-9-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Apr 14, 2011 at 10:03:42AM +0100, Chris Wilson wrote: > A few operations we do in order to move the object into the display > plane it is important for future safety to forbid whilst pinned. As a > result, we want to pin afterwards. At the moment, setting to the display > plane of an unbound object is simply to bind it, so > set_to_display_plane() becomes a no-op. After the movement all three code-paths suffer from if (ret) goto foo_unpin; before anything is actually pinned. With that fixed, it's Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48