From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 10/13] drm/i915: Use the CPU domain for snooped pwrites Date: Thu, 14 Apr 2011 19:40:53 +0200 Message-ID: <20110414174052.GF3408@viiv.ffwll.ch> References: <1302771827-26112-1-git-send-email-chris@chris-wilson.co.uk> <1302771827-26112-11-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wy0-f177.google.com (mail-wy0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id D88889F7CC for ; Thu, 14 Apr 2011 10:41:00 -0700 (PDT) Received: by wyb28 with SMTP id 28so2049765wyb.36 for ; Thu, 14 Apr 2011 10:40:59 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1302771827-26112-11-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Apr 14, 2011 at 10:03:44AM +0100, Chris Wilson wrote: > The docs warn us to be particularly careful not to write to a snooped > page through the GTT. Fortunately, this ties in very well with the > existing pwrite infrastucture to use the CPU domain where preferable and > the API already implies that the write is CPU linear.. Perhaps add "... careful not to write to a snooped page through the GTT *on pre-snb*". On snb it better work (but might be beneficial)! Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48