From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: Combine pinning after setting to the display plane Date: Fri, 15 Apr 2011 14:11:25 +0200 Message-ID: <20110415121123.GA3503@viiv.ffwll.ch> References: <1302771827-26112-9-git-send-email-chris@chris-wilson.co.uk> <1302847454-716-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wy0-f177.google.com (mail-wy0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 14EFA9E77A for ; Fri, 15 Apr 2011 05:11:30 -0700 (PDT) Received: by wyb28 with SMTP id 28so2778371wyb.36 for ; Fri, 15 Apr 2011 05:11:30 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1302847454-716-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Apr 15, 2011 at 07:04:13AM +0100, Chris Wilson wrote: > We need to perform a few operations in order to move the object into the > display plane (where it can be accessed coherently by the display > engine) that are important for future safety to forbid whilst pinned. As a > result, we want to need to perform some of operations before pinning, > but some are required once we have been bound into the GTT. So combine > the pinning performed by all the callers with set_to_display_plane(), so > this complication is contained within the single function. The latest version from -next-proposed with the fail_unpin: hunk reinstated does indeed get rid of the cacheline dirt I've seen on my ilk. But in that version you're calling set_to_gtt_domain which calls flush_gpu_write_domain and then waits synchronously when obj->pending_gpu_write is set. Which is almost guaranteed to happen for pageflips. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48