From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932065Ab1DWOqN (ORCPT ); Sat, 23 Apr 2011 10:46:13 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:48588 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754648Ab1DWOqM (ORCPT ); Sat, 23 Apr 2011 10:46:12 -0400 Date: Sat, 23 Apr 2011 15:47:07 +0100 From: Alan Cox To: Jean Delvare Cc: Grant Likely , LKML Subject: Re: [PATCH] gpio: New driver for the Intel 82801 (ICH) GPIO pins Message-ID: <20110423154707.454e1010@lxorguk.ukuu.org.uk> In-Reply-To: <20110423154528.4145698d@endymion.delvare> References: <20110419145303.111aead7@endymion.delvare> <20110423154528.4145698d@endymion.delvare> X-Mailer: Claws Mail 3.7.8 (GTK+ 2.22.0; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > And a technical question (which makes me feel somewhat ashamed as I > guess I really should know the answer): the ICH is using I/O ports for > GPIO control, not a memory mapping. Would basic_mmio_gpio work for it > still? basic_mmio_gpio would need to use iomap for this and a lot of platforms don't support generic iomap - so no it won't. You don't generally want want to create sub platform devices anyway without care as it makes sysfs, pci removal and power management ugly and takes up *more* memory than repeating the code in the first places. Alan