From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>, Li Zefan <lizf@cn.fujitsu.com>,
Miao Xie <miaox@cn.fujitsu.com>
Cc: kosaki.motohiro@jp.fujitsu.com
Subject: [RFC PATCH] cpuset: fix cpuset_cpus_allowed_fallback() don't update tsk->rt.nr_cpus_allowed
Date: Thu, 28 Apr 2011 23:20:50 +0900 (JST) [thread overview]
Message-ID: <20110428232228.3D57.A69D9226@jp.fujitsu.com> (raw)
Oleg, Peter,
I apologize if I misunderstand a code. I'm afraid we need following
patch. Is there any gurantte that cpusets user task is not RT task?
>From 400e24f7b6e15d1397dc82d74fdd1e0a631493ef Mon Sep 17 00:00:00 2001
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Date: Thu, 28 Apr 2011 16:14:16 +0900
Subject: [PATCH] cpuset: fix cpuset_cpus_allowed_fallback() don't update tsk->rt.nr_cpus_allowed
The rule is, we have to update tsk->rt.nr_cpus_allowed too if we change
tsk->cpus_allowed.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>
---
include/linux/cpuset.h | 1 +
kernel/cpuset.c | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h
index f20eb8f..42dcbdc 100644
--- a/include/linux/cpuset.h
+++ b/include/linux/cpuset.h
@@ -147,6 +147,7 @@ static inline void cpuset_cpus_allowed(struct task_struct *p,
static inline int cpuset_cpus_allowed_fallback(struct task_struct *p)
{
cpumask_copy(&p->cpus_allowed, cpu_possible_mask);
+ p->rt.nr_cpus_allowed = cpumask_weight(&p->cpus_allowed);
return cpumask_any(cpu_active_mask);
}
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 1ceeb04..6e5bbe8 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -2220,6 +2220,7 @@ int cpuset_cpus_allowed_fallback(struct task_struct *tsk)
cpumask_copy(&tsk->cpus_allowed, cpu_possible_mask);
cpu = cpumask_any(cpu_active_mask);
}
+ tsk->rt.nr_cpus_allowed = cpumask_weight(&tsk->cpus_allowed);
return cpu;
}
--
1.7.3.1
next reply other threads:[~2011-04-28 14:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 14:20 KOSAKI Motohiro [this message]
2011-04-28 16:11 ` [RFC PATCH] cpuset: fix cpuset_cpus_allowed_fallback() don't update tsk->rt.nr_cpus_allowed Oleg Nesterov
2011-05-02 10:42 ` KOSAKI Motohiro
2011-05-02 10:55 ` [PATCH 1/2] " KOSAKI Motohiro
2011-05-11 16:05 ` Peter Zijlstra
2011-05-13 5:48 ` KOSAKI Motohiro
2011-05-13 6:42 ` Yong Zhang
2011-05-13 7:33 ` KOSAKI Motohiro
2011-05-13 7:43 ` Yong Zhang
2011-05-13 9:34 ` KOSAKI Motohiro
2011-05-13 17:02 ` Peter Zijlstra
2011-05-14 11:17 ` KOSAKI Motohiro
2011-05-16 13:37 ` Yong Zhang
2011-05-19 8:45 ` Peter Zijlstra
2011-05-19 8:54 ` Yong Zhang
2011-05-15 18:55 ` Paul E. McKenney
2011-05-16 13:26 ` Yong Zhang
2011-05-19 6:06 ` [PATCH v2 1/2] rcu: don't bind offline cpu KOSAKI Motohiro
2011-05-19 6:08 ` [PATCH v2 2/2] cpuset: fix cpuset_cpus_allowed_fallback() don't update tsk->rt.nr_cpus_allowed KOSAKI Motohiro
2011-05-28 16:35 ` [tip:sched/urgent] cpuset: Fix cpuset_cpus_allowed_fallback(), " tip-bot for KOSAKI Motohiro
2011-06-20 10:20 ` Peter Zijlstra
2011-06-21 9:54 ` KOSAKI Motohiro
2011-05-19 8:34 ` [PATCH v2 1/2] rcu: don't bind offline cpu Peter Zijlstra
2011-05-19 8:50 ` KOSAKI Motohiro
2011-05-19 9:41 ` Peter Zijlstra
2011-05-19 10:12 ` KOSAKI Motohiro
2011-05-19 11:41 ` Peter Zijlstra
2011-05-20 22:46 ` Paul E. McKenney
2011-05-19 8:55 ` Peter Zijlstra
2011-05-02 10:56 ` [PATCH 2/2] sched, cpuset: introduce do_set_cpus_allowed() helper function KOSAKI Motohiro
2011-05-02 12:58 ` [RFC PATCH] cpuset: fix cpuset_cpus_allowed_fallback() don't update tsk->rt.nr_cpus_allowed Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110428232228.3D57.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=miaox@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.