From: Jiri Pirko <jpirko@redhat.com>
To: "Michał Mirosław" <mirqus@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, xemul@openvz.org
Subject: Re: [PATCH net-next-2.6] veth: remove unneeded ifname code from veth_newlink()
Date: Sat, 30 Apr 2011 12:16:48 +0200 [thread overview]
Message-ID: <20110430101647.GC2658@psychotron.orion> (raw)
In-Reply-To: <BANLkTikUAGWhNnCrebQpVttorqVxfD6KWw@mail.gmail.com>
Fri, Apr 22, 2011 at 11:49:40AM CEST, mirqus@gmail.com wrote:
>W dniu 22 kwietnia 2011 11:43 użytkownik Michał Mirosław
><mirqus@gmail.com> napisał:
>> 2011/1/24 Jiri Pirko <jpirko@redhat.com>:
>>> The code is not needed because tb[IFLA_IFNAME] is already
>>> processed in rtnl_newlink(). Remove this redundancy.
>> Hi. This patch broke creation of veth devices. Reverting it fixes the issue.
>>
>> Symptoms:
>>
>> icybox:~# ip link add type veth
>> RTNETLINK answers: File exists
>> icybox:~# ip link add type veth peer veth1
>> icybox:~# ip addr
>> [...]
>> 56: D: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000
>> link/ether e6:57:58:52:03:50 brd ff:ff:ff:ff:ff:ff
>> 57: veth0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN qlen 1000
>> link/ether c2:c2:a2:d5:d5:3a brd ff:ff:ff:ff:ff:ff
>
>Hmm. I was too quick. Reverting it fixes only first problem - "ip link
>add type veth" adds new veth pair now, but "ip link add type veth peer
>veth1" gives the same result as above.
I gusee you should do:
ip link add type veth peer name veth1
>
>Best Regards,
>Michał Mirosław
next prev parent reply other threads:[~2011-04-30 10:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 15:45 [PATCH net-next-2.6] veth: remove unneeded ifname code from veth_newlink() Jiri Pirko
2011-01-25 7:18 ` David Miller
2011-04-22 9:43 ` Michał Mirosław
2011-04-22 9:44 ` Michał Mirosław
2011-04-22 9:49 ` Michał Mirosław
2011-04-28 20:27 ` David Miller
2011-04-29 13:51 ` Jiri Pirko
2011-04-30 10:16 ` Jiri Pirko [this message]
2011-04-30 9:02 ` Jiri Pirko
2011-04-30 11:28 ` Jiri Pirko
2011-05-02 22:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110430101647.GC2658@psychotron.orion \
--to=jpirko@redhat.com \
--cc=davem@davemloft.net \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.