From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [Pv-drivers] [PATCH] vmxnet3: Consistently disable irqs when taking adapter->cmd_lock Date: Fri, 06 May 2011 13:12:11 -0700 (PDT) Message-ID: <20110506.131211.39193090.davem@davemloft.net> References: <1304706773-21348-1-git-send-email-roland@kernel.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: sbhatewara@vmware.com, roland@kernel.org, pv-drivers@vmware.com, netdev@vger.kernel.org To: scottjg@vmware.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:38916 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754292Ab1EFUMn (ORCPT ); Fri, 6 May 2011 16:12:43 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Scott Goldman Date: Fri, 6 May 2011 13:10:29 -0700 >> >> On Fri, 6 May 2011, Roland Dreier wrote: >> >> > From: Roland Dreier >> > >> > Using the vmxnet3 driver produces a lockdep warning because >> >> > Signed-off-by: Roland Dreier >> >> >> Roland, thanks for the analysis and the patch. >> >> Signed-off-by: Shreyas N Bhatewara > > Likewise, seems pretty sane to me. The command register operations are only control-path operations and disabling interrupts for the duration is probably not a big deal. Touching the cmd reg will result a VMEXIT, where the guest won't be processing interrupts anyway. > > Signed-off-by: Scott J. Goldman Applied, thanks everyone.