From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lu Guanqun <guanqun.lu@intel.com>
Cc: Takashi Iwai <tiwai@suse.de>, Koul Vinod <vinod.koul@intel.com>,
ALSA <alsa-devel@alsa-project.org>, Liam Girdwood <lrg@ti.com>,
Wang Xingchao <xingchao.wang@intel.com>
Subject: Re: [PATCH v2 10/10] ASoC: mrst_machine: add initial config to machine driver
Date: Fri, 6 May 2011 13:54:40 +0100 [thread overview]
Message-ID: <20110506125437.GJ23729@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110506054649.26312.81715.stgit@localhost>
On Fri, May 06, 2011 at 01:46:49PM +0800, Lu Guanqun wrote:
> + /* DMIC configuration: mono output to PCM2 */
> + snd_soc_update_bits(codec, UPD9976_MICCTRL, BIT(1)|BIT(0), 0x1);
> +
> + /* Set MIC2 to pseudo-differential */
> + snd_soc_update_bits(codec, UPD9976_MICSELVOL, BIT(4), BIT(4));
> +
These look like regular routing controls to me... If they do need to be
set with magic writes they should be platform data but things like
pseudo differential inputs are normally just represented as two single
ended inputs for which userspace just happens to choose a path that
looks differential.
prev parent reply other threads:[~2011-05-06 12:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 5:45 [PATCH v2 00/10] ASoC Support For Moorestown Lu Guanqun
2011-05-06 5:46 ` [PATCH v2 01/10] ASoC: upd9976: Add Renesas uPD9976 codec driver Lu Guanqun
2011-05-06 10:17 ` Mark Brown
2011-05-07 14:21 ` Lu Guanqun
2011-05-07 14:27 ` Mark Brown
2011-05-07 14:43 ` Lu Guanqun
2011-05-06 5:46 ` [PATCH v2 02/10] ASoC: sst_platform: modify current cpu dai driver to suit the needs for moorestown platform Lu Guanqun
2011-05-06 5:46 ` [PATCH v2 03/10] ASoC: mrst_machine: add moorestown machine driver Lu Guanqun
2011-05-06 5:46 ` [PATCH v2 04/10] ASoC: upd9976: add capture ability for dai driver Lu Guanqun
2011-05-06 5:46 ` [PATCH v2 05/10] ASoC: upd9976: add DMIC support Lu Guanqun
2011-05-06 11:07 ` Mark Brown
2011-05-06 5:46 ` [PATCH v2 06/10] ASoC: upd9976: add Analog MIC support Lu Guanqun
2011-05-06 5:46 ` [PATCH v2 07/10] ASoC: upd9976: add jack detection function Lu Guanqun
2011-05-06 12:53 ` Mark Brown
2011-05-06 5:46 ` [PATCH v2 08/10] ASoC: mrst_machine: add capture functionality Lu Guanqun
2011-05-06 5:46 ` [PATCH v2 09/10] ASoC: mrst_machine: add jack detection support Lu Guanqun
2011-05-06 5:46 ` [PATCH v2 10/10] ASoC: mrst_machine: add initial config to machine driver Lu Guanqun
2011-05-06 12:54 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110506125437.GJ23729@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=guanqun.lu@intel.com \
--cc=lrg@ti.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
--cc=xingchao.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.