From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Fri, 6 May 2011 15:28:56 -0500
Subject: [U-Boot] [PATCH 1/2] NS16550: buffer reads
In-Reply-To: <BANLkTinMmxFossBeT2yJ-Tp70A9SD+usvw@mail.gmail.com>
References: <20110406203012.GA30167@schlenkerla.am.freescale.net>
	<20110406204212.76780151F83@gemini.denx.de>
	<20110406162829.3507733b@schlenkerla.am.freescale.net>
	<BANLkTinMmxFossBeT2yJ-Tp70A9SD+usvw@mail.gmail.com>
Message-ID: <20110506152856.6b3853ba@schlenkerla.am.freescale.net>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wed, 4 May 2011 16:30:00 -0700
Simon Glass <sjg@chromium.org> wrote:

> Hi Scott,
> 
> This is a very useful patch and it works well. I have taken the liberty of
> modifying it slightly, because I think you should subtract 1 from the port
> number that you pass to NS16550. For some reason the 'COM' ports are
> numbered from 1 instead of 0.

Thanks for spotting!

>Please see below, and sorry if the patch doesn't come through cleanly.

The whitespace got mangled.

There's another thing that needs to be fixed -- the signatures
of the 16550 functions should not change when the feature is disabled (see
the discussion on http://patchwork.ozlabs.org/patch/90066/), or it'll
break boards like linkstation.

I'll include both fixes in my respin.

-Scott