From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932573Ab1EFSto (ORCPT ); Fri, 6 May 2011 14:49:44 -0400 Received: from outmail007.snc4.facebook.com ([66.220.144.139]:37479 "EHLO mx-out.facebook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932541Ab1EFStn (ORCPT ); Fri, 6 May 2011 14:49:43 -0400 X-Greylist: delayed 300 seconds by postgrey-1.27 at vger.kernel.org; Fri, 06 May 2011 14:49:43 EDT Date: Fri, 6 May 2011 11:44:38 -0700 From: Arun Sharma To: David Woodhouse Cc: Michal Marek , Arun Sharma , linux-kbuild@vger.kernel.org, lkml Subject: Re: [PATCH] Add $KERNELRELEASE to firmware install path Message-ID: <20110506184438.GA30417@dev1756.snc6.facebook.com> References: <20110505173939.GA20575@dev1756.snc6.facebook.com> <4DC3CA39.30806@suse.cz> <1304677113.20656.2.camel@i7.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1304677113.20656.2.camel@i7.infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 06, 2011 at 11:18:32AM +0100, David Woodhouse wrote: > On Fri, 2011-05-06 at 12:15 +0200, Michal Marek wrote: > > > > On 5.5.2011 19:39, Arun Sharma wrote: > > > Useful in the presence of multiple kernels with different > > > firmware versions. > > > > The changelog should also include the udev version that is able to find > > the firmware there (v127, August 2008). FWIW, SUSE has been using this > > patch since about that time, but we forgot to push this :-|. Anyway > > No, this is fundamentally broken. Do not do it. > > The firmware lives in /lib/firmware, not in /lib/firmware/$KERNELVERSION I'm not trying to change the way the kernel deals with firmware or anything. Just trying to make the vanilla kernel packaging scripts more usable for us. Without this change, if you have two kernel rpms/debs from different kernel versions installed, they'll result in a namespace conflict (rpm/deb install will fail), which gets resolved by this patch. -Arun