All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Don Zickus <dzickus@redhat.com>
Cc: Huang Ying <ying.huang@intel.com>,
	linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
	Robert Richter <robert.richter@amd.com>,
	Andi Kleen <ak@linux.intel.com>, Borislav Petkov <bp@alien8.de>
Subject: Re: [RFC] x86, NMI, Treat unknown NMI as hardware error
Date: Fri, 13 May 2011 15:00:11 +0200	[thread overview]
Message-ID: <20110513130011.GA6474@elte.hu> (raw)
In-Reply-To: <20110513124523.GM13984@redhat.com>


* Don Zickus <dzickus@redhat.com> wrote:

> On Fri, May 13, 2011 at 04:23:38PM +0800, Huang Ying wrote:
> > In general, unknown NMI is used by hardware and firmware to notify
> > fatal hardware errors to OS. So the Linux should treat unknown NMI as
> > hardware error and go panic upon unknown NMI for better error
> > containment.
> 
> I have a couple of concerns about this patch.  One I don't think BIOSes
> are ready for this.  I have Intel Westmere boxes that say they have a
> valid HEST, GHES, and EINJ table, but when I inject an error there is no
> GHES record.  This leaves me with an unknown NMI and panic.  Yeah, it is a
> BIOS bug I guess, but I think vendors are going to be slow fixing all this
> stuff (my Nehalem box is in even worse shape with this stuff).

Agreed, doing this is not a very good idea - we have spurious unknown NMIs 
again and again, crashing the box is not a good idea.

What should be done instead is to add an event for unknown NMIs, which can then 
be processed by the RAS daemon to implement policy.

By using 'active' event filters it could even be set on a system to panic the 
box by default.

Thanks,

	Ingo

  reply	other threads:[~2011-05-13 13:00 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-13  8:23 [RFC] x86, NMI, Treat unknown NMI as hardware error Huang Ying
2011-05-13 12:45 ` Don Zickus
2011-05-13 13:00   ` Ingo Molnar [this message]
2011-05-13 13:24     ` huang ying
2011-05-13 15:20       ` Ingo Molnar
2011-05-13 16:00         ` Don Zickus
2011-05-16 11:29           ` Ingo Molnar
2011-05-16 19:19             ` Don Zickus
2011-05-17  8:50               ` Ingo Molnar
2011-05-17  7:41             ` Huang Ying
2011-05-17  8:53               ` Ingo Molnar
2011-05-19  6:44                 ` Huang Ying
2011-05-20 11:58                   ` Ingo Molnar
2011-05-14  0:56         ` huang ying
2011-05-13 13:17   ` huang ying
2011-05-13 13:51     ` Don Zickus
2011-05-14  0:20       ` huang ying
2011-05-14  4:11         ` Andi Kleen
2011-05-13 15:17 ` Cyrill Gorcunov
2011-05-14  0:26   ` huang ying
2011-05-14  7:51     ` Cyrill Gorcunov
2011-05-15  0:06       ` huang ying
2011-05-15  6:34         ` Cyrill Gorcunov
2011-05-16  1:09           ` Huang Ying
2011-05-16 19:03             ` Don Zickus
2011-05-16 19:53               ` Cyrill Gorcunov
2011-05-17  5:39               ` Huang Ying
2011-05-17 14:24                 ` Don Zickus
2011-05-17 16:38                   ` Andi Kleen
2011-05-17 17:57                     ` Don Zickus
2011-05-17 18:18                       ` Andi Kleen
2011-05-17 19:07                         ` Don Zickus
2011-05-20  8:13                           ` Huang Ying
2011-06-09 12:09                             ` Don Zickus
2011-06-09 15:22                               ` Cyrill Gorcunov
2011-06-13  1:34                               ` Huang Ying
2011-05-16 19:44             ` Cyrill Gorcunov
2011-05-17  7:32               ` Huang Ying
2011-05-14  0:47   ` huang ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110513130011.GA6474@elte.hu \
    --to=mingo@elte.hu \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=bp@alien8.de \
    --cc=dzickus@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robert.richter@amd.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.