All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: Ben Dooks <ben-linux@fluff.org>,
	Marc Zyngier <marc.zyngier@arm.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	linux-mtd@lists.infradead.org,
	Philipp Zabel <philipp.zabel@gmail.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Andrew Victor <linux@maxim.org.za>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 8/8] MTD: physmap: let set_vpp() pass a platform_device instead of a map_info
Date: Mon, 16 May 2011 21:56:44 +0100	[thread overview]
Message-ID: <20110516205644.GG13659@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <BANLkTi=-Lcg5Wk7yuipTTzrSxs0nNmpMaw@mail.gmail.com>

On Mon, May 16, 2011 at 11:06:10PM +0800, Eric Miao wrote:
> On Mon, May 16, 2011 at 10:59 PM, Marc Zyngier <marc.zyngier@arm.com> wrote:
> > The set_vpp() method provided by physmap passes a map_info back to
> > the platform code, which has little relevance as far as the platform
> > is concerned (this parameter is completely unused).
> >
> > Instead, pass the platform_device, which can be used in the pismo
> > driver to retrieve some important information in a nicer way, instead
> > of the hack that was in place.
> 
> Not really sure if a 'struct device' would be more generic here, though this
> case is simply a 'struct platform_device'.

As it's a platform device driver (at the moment), passing the platform
device seems logical.

If it becomes an DT based device driver, then we need some other way of
describing the set_vpp etc functionality as we can't describe function
pointers in DT (the same problem goes for a lot of platform device
drivers.)

WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 8/8] MTD: physmap: let set_vpp() pass a platform_device instead of a map_info
Date: Mon, 16 May 2011 21:56:44 +0100	[thread overview]
Message-ID: <20110516205644.GG13659@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <BANLkTi=-Lcg5Wk7yuipTTzrSxs0nNmpMaw@mail.gmail.com>

On Mon, May 16, 2011 at 11:06:10PM +0800, Eric Miao wrote:
> On Mon, May 16, 2011 at 10:59 PM, Marc Zyngier <marc.zyngier@arm.com> wrote:
> > The set_vpp() method provided by physmap passes a map_info back to
> > the platform code, which has little relevance as far as the platform
> > is concerned (this parameter is completely unused).
> >
> > Instead, pass the platform_device, which can be used in the pismo
> > driver to retrieve some important information in a nicer way, instead
> > of the hack that was in place.
> 
> Not really sure if a 'struct device' would be more generic here, though this
> case is simply a 'struct platform_device'.

As it's a platform device driver (at the moment), passing the platform
device seems logical.

If it becomes an DT based device driver, then we need some other way of
describing the set_vpp etc functionality as we can't describe function
pointers in DT (the same problem goes for a lot of platform device
drivers.)

  parent reply	other threads:[~2011-05-16 20:57 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-16 14:59 [PATCH v5 0/8] Switch ARM platforms from integrator-flash to physmap Marc Zyngier
2011-05-16 14:59 ` Marc Zyngier
2011-05-16 14:59 ` [PATCH v5 1/8] MTD: Add integrator-flash feature " Marc Zyngier
2011-05-16 14:59   ` Marc Zyngier
2011-05-17  5:37   ` Artem Bityutskiy
2011-05-17  5:37     ` Artem Bityutskiy
2011-05-17  5:46     ` Artem Bityutskiy
2011-05-17  5:46       ` Artem Bityutskiy
2011-05-17  7:43       ` Russell King - ARM Linux
2011-05-17  7:43         ` Russell King - ARM Linux
2011-05-17  8:13         ` Artem Bityutskiy
2011-05-17  8:13           ` Artem Bityutskiy
2011-05-17  8:16           ` Artem Bityutskiy
2011-05-17  8:16             ` Artem Bityutskiy
2011-05-17  8:49           ` Marc Zyngier
2011-05-17  8:49             ` Marc Zyngier
2011-05-17  9:05             ` Artem Bityutskiy
2011-05-17  9:05               ` Artem Bityutskiy
2011-05-19 11:13             ` Artem Bityutskiy
2011-05-19 11:13               ` Artem Bityutskiy
2011-05-19 19:25               ` Russell King - ARM Linux
2011-05-19 19:25                 ` Russell King - ARM Linux
2011-05-24  4:43   ` Mike Frysinger
2011-05-24  4:43     ` Mike Frysinger
2011-05-16 14:59 ` [PATCH v5 2/8] ARM: Realview: Use physmap driver instead of integrator-flash Marc Zyngier
2011-05-16 14:59   ` Marc Zyngier
2011-05-16 14:59 ` [PATCH v5 3/8] ARM: Versatile: " Marc Zyngier
2011-05-16 14:59   ` Marc Zyngier
2011-05-16 14:59 ` [PATCH v5 4/8] ARM: VExpress: " Marc Zyngier
2011-05-16 14:59   ` Marc Zyngier
2011-05-16 14:59 ` [PATCH v5 5/8] ARM: Integrator/AP: " Marc Zyngier
2011-05-16 14:59   ` Marc Zyngier
2011-05-16 14:59 ` [PATCH v5 6/8] ARM: Integrator/CP: " Marc Zyngier
2011-05-16 14:59   ` Marc Zyngier
2011-05-16 14:59 ` [PATCH v5 7/8] MTD: Remove integrator-flash Marc Zyngier
2011-05-16 14:59   ` Marc Zyngier
2011-05-16 14:59 ` [PATCH v5 8/8] MTD: physmap: let set_vpp() pass a platform_device instead of a map_info Marc Zyngier
2011-05-16 14:59   ` Marc Zyngier
2011-05-16 15:06   ` Eric Miao
2011-05-16 15:06     ` Eric Miao
2011-05-16 15:14     ` Marc Zyngier
2011-05-16 15:14       ` Marc Zyngier
2011-05-16 20:56     ` Russell King - ARM Linux [this message]
2011-05-16 20:56       ` Russell King - ARM Linux
2011-05-17  8:17   ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-17  8:17     ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110516205644.GG13659@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=ben-linux@fluff.org \
    --cc=dwmw2@infradead.org \
    --cc=eric.y.miao@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux@maxim.org.za \
    --cc=marc.zyngier@arm.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=philipp.zabel@gmail.com \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.