Re: [PATCH 2/5] tsc2007: Add max_rt module parameter.

[Thierry Reding <thierry.reding@avionic-design.de>]

[-- Attachment #1: Type: text/plain, Size: 1532 bytes --]

* Dmitry Torokhov wrote:
> Hi Thierry,
> 
> On Mon, May 16, 2011 at 10:33:00AM +0200, Thierry Reding wrote:
> > Finger touch events or very quick stylus events on low-quality panels
> > can cause the tsc2007 to read bogus values. Looking at oscilloscope
> > snapshots, this seems to be caused by the touch event disappearing
> > during the measurements. These bogus values result in misclicks, where
> > the X and Y values deviate from the real position.
> > 
> > Most of these misclicks can be filtered out by setting a low enough
> > threshold for the maximum resistance (which is loosely the inverse of
> > the pressure) allowed to consider a set of values valid. Since this
> > behaviour is largely dependent on the type and quality of the panel,
> > this commit introduces the max_rt parameter. The default value is kept
> > at MAX_12BIT.
> 
> I expect that the values, once selected, will not be changed for a given
> panel, so why don't we pass max_rt (and poll_delay and poll_interval) vi
> platform (board) data instead of being module parameters?

I was using module parameters because it allows the parameters to be tuned at
runtime. You are correct however in that they don't vary after being selected
once. I can resend an updated patch series with those parameters added to the
platform data if you prefer.

By the way, Kwangwoo's email address no longer seems to be valid. Searching
the kernel tree, there also seems to be kwangwoo.lee@gmail.com. Do you know
if it is current?

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]