From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nadav Har'El" Subject: Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling Date: Tue, 17 May 2011 21:11:32 +0300 Message-ID: <20110517181132.GA16262@fermat.math.technion.ac.il> References: <1305575004-nyh@il.ibm.com> <201105161948.p4GJm1as001742@rice.haifa.ibm.com> <20110517131918.GA3809@amt.cnet> <4DD27998.1040105@redhat.com> <20110517143532.GA2490@fermat.math.technion.ac.il> <4DD2902C.9050403@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Marcelo Tosatti , kvm@vger.kernel.org, gleb@redhat.com To: Avi Kivity Return-path: Received: from mailgw12.technion.ac.il ([132.68.225.12]:29114 "EHLO mailgw12.technion.ac.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755908Ab1EQSLe (ORCPT ); Tue, 17 May 2011 14:11:34 -0400 Content-Disposition: inline In-Reply-To: <4DD2902C.9050403@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, May 17, 2011, Avi Kivity wrote about "Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling": > >VMCSs. If we had only a list of VMCSs, how can we mark the vcpus as being > >not > >currently loaded (cpu=-1)? > > > > ->launched and ->cpu simply move into struct vmcs. As I explained in the sister thread (this discussion is becoming a tree ;-)) this is what I planned to do, until it dawned on me that I can't, because "cpu" isn't part of vmx (where the vmcs and launched sit in the standard KVM), but rather part of vcpu... When I gave up trying to "solve" these interdependencies and avoiding modifying half of KVM, I came up with the current solution. Maybe I'm missing something - I'd be happy if we do find a solution that simplifies this code. -- Nadav Har'El | Tuesday, May 17 2011, 14 Iyyar 5771 nyh@math.technion.ac.il |----------------------------------------- Phone +972-523-790466, ICQ 13349191 |Why do we drive on a parkway and park on http://nadav.harel.org.il |a driveway?