From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nadav Har'El" Subject: Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling Date: Tue, 17 May 2011 22:30:30 +0300 Message-ID: <20110517193030.GA21656@fermat.math.technion.ac.il> References: <1305575004-nyh@il.ibm.com> <201105161948.p4GJm1as001742@rice.haifa.ibm.com> <20110517131918.GA3809@amt.cnet> <4DD27998.1040105@redhat.com> <20110517143532.GA2490@fermat.math.technion.ac.il> <4DD2902C.9050403@redhat.com> <20110517181132.GA16262@fermat.math.technion.ac.il> <20110517184336.GA10394@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , kvm@vger.kernel.org, gleb@redhat.com To: Marcelo Tosatti Return-path: Received: from mailgw12.technion.ac.il ([132.68.225.12]:26997 "EHLO mailgw12.technion.ac.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756536Ab1EQTag (ORCPT ); Tue, 17 May 2011 15:30:36 -0400 Content-Disposition: inline In-Reply-To: <20110517184336.GA10394@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, May 17, 2011, Marcelo Tosatti wrote about "Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling": > > this is what I planned to do, until it dawned on me that I can't, because "cpu" > > isn't part of vmx (where the vmcs and launched sit in the standard KVM), but >... > vcpu->cpu remains there. There is a new ->cpu field on struct vmcs, just > as saved_vmcs has in the current patches, to note the cpu which the VMCS > was last loaded. So we'll have two fields, vmx.vcpu.cpu and vmx.vmcs.cpu, which are supposed to always contain the same value. Are you fine with that? > As mentioned there is no need to set "vcpu->cpu = -1" in __vcpu_clear, > the IPI handler, that can be done in vcpu_clear. Right, this is true. -- Nadav Har'El | Tuesday, May 17 2011, 14 Iyyar 5771 nyh@math.technion.ac.il |----------------------------------------- Phone +972-523-790466, ICQ 13349191 |"A mathematician is a device for turning http://nadav.harel.org.il |coffee into theorems" -- P. Erdos