From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nadav Har'El" Subject: Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling Date: Wed, 18 May 2011 08:52:36 +0300 Message-ID: <20110518055236.GA1230@fermat.math.technion.ac.il> References: <1305575004-nyh@il.ibm.com> <201105161948.p4GJm1as001742@rice.haifa.ibm.com> <20110517131918.GA3809@amt.cnet> <4DD27998.1040105@redhat.com> <20110517143532.GA2490@fermat.math.technion.ac.il> <4DD2902C.9050403@redhat.com> <20110517181132.GA16262@fermat.math.technion.ac.il> <20110517184336.GA10394@amt.cnet> <20110517193030.GA21656@fermat.math.technion.ac.il> <20110517195253.GB11065@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , kvm@vger.kernel.org, gleb@redhat.com To: Marcelo Tosatti Return-path: Received: from mailgw12.technion.ac.il ([132.68.225.12]:16807 "EHLO mailgw12.technion.ac.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753570Ab1ERFwp (ORCPT ); Wed, 18 May 2011 01:52:45 -0400 Content-Disposition: inline In-Reply-To: <20110517195253.GB11065@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, May 17, 2011, Marcelo Tosatti wrote about "Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling": > On Tue, May 17, 2011 at 10:30:30PM +0300, Nadav Har'El wrote: > > So we'll have two fields, vmx.vcpu.cpu and vmx.vmcs.cpu, which are supposed > > to always contain the same value. Are you fine with that? > > Yes. Avi? Oops, it's even worse than I said, because if the new vmclear_local_vmcss clears the vmcs currently used on some vcpu, it will update vmcs.cpu on that vcpu to -1, but will *not* update vmx.vcpu.cpu, which remain its old value, and potentially cause problems when it is used (e.g., in x86.c) instead of vmx.vmcs.cpu. -- Nadav Har'El | Wednesday, May 18 2011, 14 Iyyar 5771 nyh@math.technion.ac.il |----------------------------------------- Phone +972-523-790466, ICQ 13349191 |An egotist is a person of low taste, more http://nadav.harel.org.il |interested in himself than in me.