From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nadav Har'El" Subject: Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling Date: Wed, 18 May 2011 12:02:54 +0300 Message-ID: <20110518090254.GA14994@fermat.math.technion.ac.il> References: <20110517131918.GA3809@amt.cnet> <4DD27998.1040105@redhat.com> <20110517143532.GA2490@fermat.math.technion.ac.il> <4DD2902C.9050403@redhat.com> <20110517181132.GA16262@fermat.math.technion.ac.il> <20110517184336.GA10394@amt.cnet> <20110517193030.GA21656@fermat.math.technion.ac.il> <20110517195253.GB11065@amt.cnet> <20110518055236.GA1230@fermat.math.technion.ac.il> <4DD383C6.5070001@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Marcelo Tosatti , kvm@vger.kernel.org, gleb@redhat.com To: Avi Kivity Return-path: Received: from mailgw12.technion.ac.il ([132.68.225.12]:60829 "EHLO mailgw12.technion.ac.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752031Ab1ERJJ2 (ORCPT ); Wed, 18 May 2011 05:09:28 -0400 Content-Disposition: inline In-Reply-To: <4DD383C6.5070001@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, May 18, 2011, Avi Kivity wrote about "Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling": > I did a quick audit and it seems fine. If it isn't, we'll fix it when > we see the problem. Ok, then, I'm working on the code with the new approach. My fear was that some CPU 7 is taken down, but vcpu.cpu remains 7 (not set to -1). If cpu 7 nevers comes up again, it's not a problem because when we run the same vcpu again on a different cpu, it's not 7 so we do what needs to be done on CPU switch. But, what if CPU 7 does come up again later, and we find ourselves running again on CPU 7, but it's not the same CPU 7 and we don't know it? Is this case at all possible? -- Nadav Har'El | Wednesday, May 18 2011, 14 Iyyar 5771 nyh@math.technion.ac.il |----------------------------------------- Phone +972-523-790466, ICQ 13349191 |Enjoy the new millennium; it might be http://nadav.harel.org.il |your last.