From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] drm/i915: initialize gen6 rps work queue for Ironlake+ Date: Wed, 18 May 2011 10:22:27 -0700 Message-ID: <20110518102227.55d69f59@jbarnes-desktop> References: <20110518092107.36dfeecd@jbarnes-desktop> <4DD3F5DC.904@freedesktop.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy1-pub.bluehost.com (oproxy1-pub.bluehost.com [66.147.249.253]) by gabe.freedesktop.org (Postfix) with SMTP id 3AF8A9E814 for ; Wed, 18 May 2011 10:22:43 -0700 (PDT) In-Reply-To: <4DD3F5DC.904@freedesktop.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ian Romanick Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 18 May 2011 18:37:48 +0200 Ian Romanick wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 05/18/2011 06:21 PM, Jesse Barnes wrote: > > Looks like I didn't merge Ben's RPS work queue stuff correctly with the > > new IRQ split code (diff was sparse enough that git didn't complain). > > This should prevent null derefs on ILK+ due to the missing work queue. > > Is this actually needed on Ironlake (i.e., gen5)? > > > Signed-off-by: Jesse Barnes The work queue is only used on gen6, but gen6 and ilk share an irq handler. I could make the work queue init conditional on gen6 though, if that's what you're thinking. -- Jesse Barnes, Intel Open Source Technology Center