From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49312)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QMhCg-0003ec-DN
	for qemu-devel@nongnu.org; Wed, 18 May 2011 09:54:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QMhCf-0006L9-DH
	for qemu-devel@nongnu.org; Wed, 18 May 2011 09:54:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47866)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QMhCf-0006Kq-62
	for qemu-devel@nongnu.org; Wed, 18 May 2011 09:54:21 -0400
Date: Wed, 18 May 2011 10:54:16 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20110518105416.0bad0a51@doriath>
In-Reply-To: <BANLkTi=naWSyQ_pj=kLyzceh+vRe1JkKFw@mail.gmail.com>
References: <1305679930-4215-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1305679930-4215-5-git-send-email-mdroth@linux.vnet.ibm.com>
	<BANLkTi=naWSyQ_pj=kLyzceh+vRe1JkKFw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v1][ 04/23] qerror: refactor error to make
 the human message reusable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: aliguori@linux.vnet.ibm.com, Anthony Liguori <aliguori@us.ibm.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org

On Wed, 18 May 2011 09:09:28 +0100
Stefan Hajnoczi <stefanha@gmail.com> wrote:

> On Wed, May 18, 2011 at 1:51 AM, Michael Roth <mdroth@linux.vnet.ibm.com>=
 wrote:
> > +#if 0
> > + =A0 =A0qerror_abort(qerror, "expected '%c' in '%s'", c, entry->desc);
> > +#else
> > + =A0 =A0fprintf(stderr, "expected '%c' in '%s'", c, entry->desc);
> > =A0 =A0 abort();
> > +#endif
>=20
> There are a couple of #if 0 in the patch, please resolve them.

Yes and this does more than the subject says.