From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nadav Har'El" Subject: Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling Date: Wed, 18 May 2011 15:19:07 +0300 Message-ID: <20110518121907.GA19@fermat.math.technion.ac.il> References: <20110517131918.GA3809@amt.cnet> <4DD27998.1040105@redhat.com> <20110517143532.GA2490@fermat.math.technion.ac.il> <4DD2902C.9050403@redhat.com> <20110517181132.GA16262@fermat.math.technion.ac.il> <20110517184336.GA10394@amt.cnet> <20110517193030.GA21656@fermat.math.technion.ac.il> <20110517195253.GB11065@amt.cnet> <20110518055236.GA1230@fermat.math.technion.ac.il> <20110518120801.GA9176@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , kvm@vger.kernel.org, gleb@redhat.com To: Marcelo Tosatti Return-path: Received: from mailgw12.technion.ac.il ([132.68.225.12]:16713 "EHLO mailgw12.technion.ac.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755576Ab1ERMTL (ORCPT ); Wed, 18 May 2011 08:19:11 -0400 Content-Disposition: inline In-Reply-To: <20110518120801.GA9176@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, May 18, 2011, Marcelo Tosatti wrote about "Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling": > Note this is not just about the code being nicer, but simplicity is > crucial, the code is tricky enough with one linked list. Unfortunately, it's not obvious that the method you suggested (and which, like I said, was the first method I considered as well, and rejected) will be simpler or less tricky, with its two "cpu" variables, vmcs pointing to l1_vmcs even in the non-nested case, and a bunch of other issues. The main benefit of the code as I already posted it was that it didn't add *any* complexity or changed anything to the non-nested case. The code I'm writing now based on your suggestions is more risky in the sense that it *may* break some things completely unrelated to nested. In any case, like I said, I'm working on a version using your and Avi's suggestions, and will send it for your review shortly. Thanks for all the ideas, Nadav. -- Nadav Har'El | Wednesday, May 18 2011, 14 Iyyar 5771 nyh@math.technion.ac.il |----------------------------------------- Phone +972-523-790466, ICQ 13349191 |Sign seen in restaurant: We Reserve The http://nadav.harel.org.il |Right To Serve Refuse To Anyone!