From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Alan Cox <alan@linux.intel.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Kay Sievers <kay.sievers@vrfy.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
Arnd Bergmann <arnd@arndb.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: BUG: NULL pointer deref in tty port / uart
Date: Wed, 18 May 2011 15:36:36 +0100 [thread overview]
Message-ID: <20110518153636.5cdcdd78@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20110518142631.GB2011@jolsa.brq.redhat.com>
> have the same issue.. looks like we should not NULL the port->tty
> if there's blocked open, but not sure what's exactly the logic
> behind "port's block_open and count" ..
A pending open is not a user of the tty as far as the rest of the stack
is concerned. I also don't see why clearing port->tty is causing this
crash because nothing on that path should ever be going via port->tty and
it isn't safe to do so.
> attached patch fixes it for me
But still breaks on hangup where we can't do that.
Where is port->tty getting misused to cause the crash, that is the bit
I'm missing somewhere.
next prev parent reply other threads:[~2011-05-18 14:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 23:12 BUG: NULL pointer deref in tty port / uart Frederic Weisbecker
2011-05-17 23:44 ` Alan Cox
2011-05-18 14:26 ` Jiri Olsa
2011-05-18 14:36 ` Alan Cox [this message]
2011-05-18 14:44 ` Jiri Olsa
2011-05-18 14:50 ` Alan Cox
2011-05-18 19:42 ` Greg KH
2011-05-19 11:19 ` Jiri Olsa
2011-05-19 12:51 ` Greg KH
2011-05-19 13:58 ` Jiri Olsa
2011-05-19 14:07 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110518153636.5cdcdd78@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=fweisbec@gmail.com \
--cc=gregkh@suse.de \
--cc=jolsa@redhat.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.