All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Jan Kara <jack@suse.cz>
Cc: tytso@mit.edu, Edward Goggin <egoggin@vmware.com>,
	linux-ext4@vger.kernel.org
Subject: Re: [PATCH 0/2] Fix sending of a barrier and transaction waiting in ext4_sync_file()
Date: Wed, 18 May 2011 10:43:27 -0700	[thread overview]
Message-ID: <20110518174327.GB20655@tux1.beaverton.ibm.com> (raw)
In-Reply-To: <1305628095-27843-1-git-send-email-jack@suse.cz>

On Tue, May 17, 2011 at 12:28:13PM +0200, Jan Kara wrote:
> 
>   Hi Ted,
> 
>   the two patches below fix ext4_sync_file() to wait for a transaction commit
> properly (return value of jbd2_log_start_commit() is not exactly what
> ext4_sync_file() thinks it is). It also optimizes / fixes sending of a barrier
> in some cases (e.g. in ordered mode with external journal we cannot really
> depend on transaction commit to issue a barrier to fs device because we don't
> seem to add inode to a transaction for overwrites).

Probably a silly nit to pick, but do you mean "flush" instead of "barrier"?

--D
> 
> I already fixed ext3 in this regard some time ago but didn't get to porting the
> patches to ext4. 
> 
> 									Honza
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2011-05-18 17:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-17 10:28 [PATCH 0/2] Fix sending of a barrier and transaction waiting in ext4_sync_file() Jan Kara
2011-05-17 10:28 ` [PATCH 1/2] jbd2: Provide function to check whether transaction will issue data barrier Jan Kara
2011-05-17 10:28 ` [PATCH 2/2] ext4: Fix waiting and sending of a barrier in ext4_sync_file() Jan Kara
2011-05-22 21:12   ` Ted Ts'o
2011-05-22 21:13     ` [PATCH 1/2] jbd2: Add function jbd2_trans_will_send_data_barrier() Theodore Ts'o
2011-05-22 21:13     ` [PATCH 2/2] ext4: Fix waiting and sending of a barrier in ext4_sync_file() Theodore Ts'o
2011-05-23 17:17       ` Jan Kara
2011-05-23 19:28         ` Ted Ts'o
2011-05-23 20:25           ` Jan Kara
2011-05-18 17:43 ` Darrick J. Wong [this message]
2011-05-19 10:51   ` [PATCH 0/2] Fix sending of a barrier and transaction waiting " Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110518174327.GB20655@tux1.beaverton.ibm.com \
    --to=djwong@us.ibm.com \
    --cc=egoggin@vmware.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.