From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: denys@visp.net.lb, netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] ipv6: reduce per device ICMP mib sizes
Date: Thu, 19 May 2011 16:19:07 -0400 (EDT) [thread overview]
Message-ID: <20110519.161907.1750862041337015528.davem@davemloft.net> (raw)
In-Reply-To: <1305803663.3028.39.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 19 May 2011 13:14:23 +0200
> [PATCH net-next-2.6] ipv6: reduce per device ICMP mib sizes.
>
> ipv6 has per device ICMP SNMP counters, taking too much space because
> they use percpu storage.
>
> needed size per device is :
> (512+4)*sizeof(long)*number_of_possible_cpus*2
>
> On a 32bit kernel, 16 possible cpus, this wastes more than 64kbytes of
> memory per ipv6 enabled network device, taken in vmalloc pool.
>
> Since ICMP messages are rare, just use shared counters (atomic_long_t)
>
> Per network space ICMP counters are still using percpu memory, we might
> also convert them to shared counters in a future patch.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
next prev parent reply other threads:[~2011-05-19 20:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 6:35 2.6.39-rc7-git11, x86/32, failed on ppp2897'th interface, PERCPU: allocation failed Denys Fedoryshchenko
2011-05-19 6:39 ` Eric Dumazet
2011-05-19 6:47 ` Denys Fedoryshchenko
2011-05-19 6:55 ` Eric Dumazet
2011-05-19 7:28 ` Denys Fedoryshchenko
2011-05-19 7:44 ` Eric Dumazet
2011-05-19 11:14 ` [PATCH net-next-2.6] ipv6: reduce per device ICMP mib sizes Eric Dumazet
2011-05-19 11:26 ` Denys Fedoryshchenko
2011-05-19 20:19 ` David Miller [this message]
2011-05-19 7:51 ` 2.6.39-rc7-git11, x86/32, failed on ppp2897'th interface, PERCPU: allocation failed David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519.161907.1750862041337015528.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=denys@visp.net.lb \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.