From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44403)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1QN2zv-0001CP-Nz
	for qemu-devel@nongnu.org; Thu, 19 May 2011 09:10:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1QN2zu-0002mc-Re
	for qemu-devel@nongnu.org; Thu, 19 May 2011 09:10:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35815)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1QN2zu-0002mB-KV
	for qemu-devel@nongnu.org; Thu, 19 May 2011 09:10:38 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4JDAacE026312
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 19 May 2011 09:10:36 -0400
Date: Thu, 19 May 2011 18:40:33 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20110519131033.GA13222@amit-x200.redhat.com>
References: <1305805037-17752-1-git-send-email-armbru@redhat.com>
	<1305805037-17752-3-git-send-email-armbru@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1305805037-17752-3-git-send-email-armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] virtio-serial: Clean up
 virtser_bus_dev_print() output
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: alevy@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com

On (Thu) 19 May 2011 [13:37:15], Markus Armbruster wrote:
> Old version looks like this in info qtree (last four lines):
> 
>           dev: virtconsole, id ""
>             dev-prop: is_console = 1
>             dev-prop: nr = 0
>             dev-prop: chardev = <null>
>             dev-prop: name = <null>
>              dev-prop-int: id: 0
>              dev-prop-int: guest_connected: 1
>              dev-prop-int: host_connected: 0
>              dev-prop-int: throttled: 0
> 
> Indentation is off, and "dev-prop-int" suggests these are properties
> you can configure with -device, which isn't the case.  The other
> buses' print_dev() callbacks don't do that.  For instance, PCI's
> output looks like this:
> 
>         class Ethernet controller, addr 00:03.0, pci id 1af4:1000 (sub 1af4:0001)
>         bar 0: i/o at 0xffffffffffffffff [0x1e]
>         bar 1: mem at 0xffffffffffffffff [0xffe]
>         bar 6: mem at 0xffffffffffffffff [0xfffe]
> 
> Change virtser_bus_dev_print() to that style.  Result:
> 
>           dev: virtconsole, id ""
>             dev-prop: is_console = 1
>             dev-prop: nr = 0
>             dev-prop: chardev = <null>
>             dev-prop: name = <null>
>             port 0, guest on, host off, throttle off

Here the original guest_connected and host_connected meant whether the
endpoints were open.  guest on/off, host on/off don't convey that
meaning.  Can't think of a short version, can you?

		Amit