From: Neil Horman <nhorman@redhat.com>
To: Andy Gospodarek <andy@greyhouse.net>
Cc: Amerigo Wang <amwang@redhat.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Jay Vosburgh <fubar@us.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
Ian Campbell <ian.campbell@citrix.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Josh Triplett <josh@joshtriplett.org>,
netdev@vger.kernel.org
Subject: Re: [V2 Patch net-next-2.6] netpoll: disable netpoll when enslave a device
Date: Thu, 19 May 2011 09:25:33 -0400 [thread overview]
Message-ID: <20110519132533.GA6729@shamino.rdu.redhat.com> (raw)
In-Reply-To: <20110519113127.GE21309@gospo.rdu.redhat.com>
On Thu, May 19, 2011 at 07:31:27AM -0400, Andy Gospodarek wrote:
> On Thu, May 19, 2011 at 04:39:53PM +0800, Amerigo Wang wrote:
> [...]
> > diff --git a/include/linux/notifier.h b/include/linux/notifier.h
> > index 621dfa1..3d82867 100644
> > --- a/include/linux/notifier.h
> > +++ b/include/linux/notifier.h
> > @@ -211,6 +211,7 @@ static inline int notifier_to_errno(int ret)
> > #define NETDEV_UNREGISTER_BATCH 0x0011
> > #define NETDEV_BONDING_DESLAVE 0x0012
> > #define NETDEV_NOTIFY_PEERS 0x0013
> > +#define NETDEV_ENSLAVE 0x0014
> >
> > #define SYS_DOWN 0x0001 /* Notify of system down */
> > #define SYS_RESTART SYS_DOWN
>
> Neil just noted the same concern I had -- the asymmetry between
> NETDEV_ENSLAVE and NETDEV_BONDING_DESLAVE bothers me a bit. I also
> don't really like the followup patch that uses 'ENSLAVE' in the bridging
> code when we typically use that language for bonding only.
>
> What about changing NETDEV_BONDING_DESLAVE to NETDEV_RELEASE and create
> NETDEV_JOIN instead of NETDEV_ENSLAVE? I would prefer that or something
> else that might use more generic language that could be applied to all
> for stacked interfaces.
JOIN and RELEASE (or perhaps LEAVE) sounds good to me.
Neil
next prev parent reply other threads:[~2011-05-19 13:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 10:00 [Patch net-next-2.6] netpoll: disable netpoll when enslave a device Amerigo Wang
2011-05-18 10:56 ` Neil Horman
2011-05-19 5:13 ` Cong Wang
2011-05-19 11:03 ` Neil Horman
2011-05-19 8:39 ` [V2 Patch " Amerigo Wang
2011-05-19 10:24 ` [Patch] bridge: call NETDEV_ENSLAVE notifiers when adding a slave Amerigo Wang
2011-05-19 10:24 ` [Bridge] " Amerigo Wang
2011-05-19 15:12 ` Stephen Hemminger
2011-05-19 15:12 ` [Bridge] " Stephen Hemminger
2011-05-19 16:04 ` Stephen Hemminger
2011-05-19 16:04 ` Stephen Hemminger
2011-05-20 3:06 ` Cong Wang
2011-05-20 3:06 ` Cong Wang
2011-05-19 11:31 ` [V2 Patch net-next-2.6] netpoll: disable netpoll when enslave a device Andy Gospodarek
2011-05-19 13:25 ` Neil Horman [this message]
2011-05-20 3:10 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519132533.GA6729@shamino.rdu.redhat.com \
--to=nhorman@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=ian.campbell@citrix.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.