All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>, linux-mips@linux-mips.org
Subject: Re: [PATCH 3/3] MIPS: DMA: Add plat_extra_sync_for_cpu()
Date: Thu, 19 May 2011 14:30:51 +0100	[thread overview]
Message-ID: <20110519133051.GA30483@linux-mips.org> (raw)
In-Reply-To: <AANLkTinAhsetaV2F8SfBZE_BtaMhhmJO2fEwL+LJpZxB@mail.gmail.com>

On Thu, Sep 09, 2010 at 05:39:32AM -0700, Kevin Cernekee wrote:

> On Thu, Sep 9, 2010 at 2:34 AM, Sergei Shtylyov <sshtylyov@mvista.com> wrote:
> >> +static inline void plat_extra_sync_for_cpu(struct device *dev,
> >> +       dma_addr_t dma_handle, unsigned long offset, size_t size,
> >> +       enum dma_data_direction direction)
> >> +{
> >> +       return;
> >
> >   Why not just empty function bodies?
> 
> For consistency with plat_extra_sync_for_device().

Consistency is good - but let's just stop the madness.  The lone return
in a void function doesn't help readability and I'm not sure how it ever
got into the code.  I just went through all the MIPS includes and cleaned
all instances I found.

  Ralf

MIPS: Remove pointless return statement from empty void functions.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

 arch/mips/include/asm/irq.h                         |    1 -
 arch/mips/include/asm/mach-generic/dma-coherence.h  |    1 -
 arch/mips/include/asm/mach-ip27/dma-coherence.h     |    1 -
 arch/mips/include/asm/mach-jazz/dma-coherence.h     |    1 -
 arch/mips/include/asm/mach-loongson/dma-coherence.h |    1 -
 arch/mips/include/asm/mach-powertv/dma-coherence.h  |    1 -
 6 files changed, 6 deletions(-)

Index: linux-queue/arch/mips/include/asm/mach-ip27/dma-coherence.h
===================================================================
--- linux-queue.orig/arch/mips/include/asm/mach-ip27/dma-coherence.h
+++ linux-queue/arch/mips/include/asm/mach-ip27/dma-coherence.h
@@ -60,7 +60,6 @@ static inline int plat_dma_supported(str
 
 static inline void plat_extra_sync_for_device(struct device *dev)
 {
-	return;
 }
 
 static inline int plat_dma_mapping_error(struct device *dev,
Index: linux-queue/arch/mips/include/asm/irq.h
===================================================================
--- linux-queue.orig/arch/mips/include/asm/irq.h
+++ linux-queue/arch/mips/include/asm/irq.h
@@ -18,7 +18,6 @@
 
 static inline void irq_dispose_mapping(unsigned int virq)
 {
-	return;
 }
 
 #ifdef CONFIG_I8259
Index: linux-queue/arch/mips/include/asm/mach-generic/dma-coherence.h
===================================================================
--- linux-queue.orig/arch/mips/include/asm/mach-generic/dma-coherence.h
+++ linux-queue/arch/mips/include/asm/mach-generic/dma-coherence.h
@@ -49,7 +49,6 @@ static inline int plat_dma_supported(str
 
 static inline void plat_extra_sync_for_device(struct device *dev)
 {
-	return;
 }
 
 static inline int plat_dma_mapping_error(struct device *dev,
Index: linux-queue/arch/mips/include/asm/mach-jazz/dma-coherence.h
===================================================================
--- linux-queue.orig/arch/mips/include/asm/mach-jazz/dma-coherence.h
+++ linux-queue/arch/mips/include/asm/mach-jazz/dma-coherence.h
@@ -50,7 +50,6 @@ static inline int plat_dma_supported(str
 
 static inline void plat_extra_sync_for_device(struct device *dev)
 {
-	return;
 }
 
 static inline int plat_dma_mapping_error(struct device *dev,
Index: linux-queue/arch/mips/include/asm/mach-loongson/dma-coherence.h
===================================================================
--- linux-queue.orig/arch/mips/include/asm/mach-loongson/dma-coherence.h
+++ linux-queue/arch/mips/include/asm/mach-loongson/dma-coherence.h
@@ -55,7 +55,6 @@ static inline int plat_dma_supported(str
 
 static inline void plat_extra_sync_for_device(struct device *dev)
 {
-	return;
 }
 
 static inline int plat_dma_mapping_error(struct device *dev,
Index: linux-queue/arch/mips/include/asm/mach-powertv/dma-coherence.h
===================================================================
--- linux-queue.orig/arch/mips/include/asm/mach-powertv/dma-coherence.h
+++ linux-queue/arch/mips/include/asm/mach-powertv/dma-coherence.h
@@ -102,7 +102,6 @@ static inline int plat_dma_supported(str
 
 static inline void plat_extra_sync_for_device(struct device *dev)
 {
-	return;
 }
 
 static inline int plat_dma_mapping_error(struct device *dev,

  reply	other threads:[~2011-05-19 13:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-08 23:02 [PATCH v2 1/3] MIPS: HIGHMEM DMA on noncoherent MIPS32 processors Kevin Cernekee
2010-09-08 23:02 ` Kevin Cernekee
2010-09-08 23:02 ` [PATCH 2/3] MIPS: Allow UserLocal on MIPS_R1 processors Kevin Cernekee
2010-09-08 23:02   ` Kevin Cernekee
2010-09-09  9:53   ` Ralf Baechle
2010-09-08 23:02 ` [PATCH 3/3] MIPS: DMA: Add plat_extra_sync_for_cpu() Kevin Cernekee
2010-09-08 23:02   ` Kevin Cernekee
2010-09-09  9:34   ` Sergei Shtylyov
2010-09-09 12:39     ` Kevin Cernekee
2011-05-19 13:30       ` Ralf Baechle [this message]
2010-09-09 17:10   ` David Daney
2010-09-09 17:34     ` Thomas Bogendoerfer
2010-09-09 18:35       ` Kevin Cernekee
2010-09-09 18:58         ` David Daney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110519133051.GA30483@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=cernekee@gmail.com \
    --cc=linux-mips@linux-mips.org \
    --cc=sshtylyov@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.