All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Borislav Petkov <bp@alien8.de>,
	LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
	Stephane Eranian <eranian@google.com>
Subject: Re: [RFC PATCH] perf: Split up buffer handling from core code
Date: Thu, 19 May 2011 16:14:59 +0200	[thread overview]
Message-ID: <20110519141456.GB1956@nowhere> (raw)
In-Reply-To: <1305793931.2466.7191.camel@twins>

On Thu, May 19, 2011 at 10:32:11AM +0200, Peter Zijlstra wrote:
> On Thu, 2011-05-19 at 09:31 +0200, Borislav Petkov wrote:
> > 
> > Ok, maybe I'm missing something looking at this from the side but
> > perf_output_copy is used only internally by perf_event.c, i.e.
> > events/core.c, why not put it into the internal.h header?
> 
> Not strictly true, but since the current inline is only valid for the
> existing perf_event.c its close enough :-)
> 
> Anyway, I agree, stick it in internal.h :-)

Great. I kept it global because I read in a review from you
that you wanted it to stay a visible API. But if you're fine
with it internal, let's move it there.

Thanks.

  reply	other threads:[~2011-05-19 14:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-19  1:06 [RFC PATCH] perf: Split up buffer handling from core code Frederic Weisbecker
2011-05-19  1:07 ` Frederic Weisbecker
2011-05-19  7:31 ` Borislav Petkov
2011-05-19  8:32   ` Peter Zijlstra
2011-05-19 14:14     ` Frederic Weisbecker [this message]
2011-05-19 14:43       ` Peter Zijlstra
2011-05-19 14:59         ` Frederic Weisbecker
2011-05-19 15:14           ` Peter Zijlstra
2011-05-19 15:15             ` Frederic Weisbecker
2011-05-19 17:20             ` Ingo Molnar
2011-05-19 17:23               ` Frederic Weisbecker
2011-05-19 17:55 ` [PATCH] " Frederic Weisbecker
2011-05-31 18:22   ` Frederic Weisbecker
2011-06-01  7:06     ` Ingo Molnar
2011-06-09 11:43   ` [tip:perf/core] " tip-bot for Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110519141456.GB1956@nowhere \
    --to=fweisbec@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=bp@alien8.de \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.