From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 3 of 3] kexec: disable iommu jumping into the kdump kernel Date: Thu, 19 May 2011 10:32:06 -0400 Message-ID: <20110519143206.GB9854@dumpdata.com> References: <20110518184946.GB14013@dumpdata.com> <4DD430A4.5000305@citrix.com> <20110518205719.GA5979@dumpdata.com> <4DD43910.6060709@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4DD43910.6060709@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Andrew Cooper , allen.m.kay@intel.com Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org > >>>What about AMD VI IOMMUs? Does it work when that IOMMU is used? > >>> > >>It worked on the AMD box I tested the code on. Like the comment > >>says - as far as I can tell, it is architecture independent code. > >>>>+ */ > >>>>+ iommu_disable_x2apic_IR(); > >>>Can't that function be done in the suspend code of the IOMMU? > >>There is a comment in iommu suspend stating that it cant and isn't > >>done, but rather is left for the local/ioapic_suspend functions > >>which dont properly work in the kexec path. > >OK, how about just moving it out of driver/passthrought/vtd then? > Because that code is fragile enough without me poking about in it. > I would prefer someone with more knowledge about IOMMU to make that > call. OK. Lets CC him here then.