From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 64.mail-out.ovh.net ([91.121.185.65]) by canuck.infradead.org with smtp (Exim 4.76 #1 (Red Hat Linux)) id 1QN7LK-0007Jn-4j for linux-mtd@lists.infradead.org; Thu, 19 May 2011 17:49:03 +0000 Date: Thu, 19 May 2011 19:37:10 +0200 From: Jean-Christophe PLAGNIOL-VILLARD To: Artem Bityutskiy Subject: Re: [PATCH v6 8/8] MTD: physmap: let set_vpp() pass a platform_device instead of a map_info Message-ID: <20110519173710.GR15292@game.jcrosoft.org> References: <1305637877-24436-1-git-send-email-marc.zyngier@arm.com> <1305637877-24436-9-git-send-email-marc.zyngier@arm.com> <1305803858.2630.67.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1305803858.2630.67.camel@localhost> Cc: Eric Miao , Philipp Zabel , Marc Zyngier , Nicolas Ferre , linux-mtd@lists.infradead.org, Ben Dooks , Russell King , David Woodhouse , Andrew Victor , linux-arm-kernel@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 14:17 Thu 19 May , Artem Bityutskiy wrote: > On Tue, 2011-05-17 at 14:11 +0100, Marc Zyngier wrote: > > The set_vpp() method provided by physmap passes a map_info back to > > the platform code, which has little relevance as far as the platform > > is concerned (this parameter is completely unused). > > > > Instead, pass the platform_device, which can be used in the pismo > > driver to retrieve some important information in a nicer way, instead > > of the hack that was in place. > > > > The empty set_vpp function in board-at572d940hf_ek.c is left untouched, > > as the board/SoC is scheduled for removal. > > > > Cc: Andrew Victor > > Cc: Nicolas Ferre > > Cc: Jean-Christophe Plagniol-Villard > > Cc: Russell King > > Cc: Philipp Zabel > > Cc: Eric Miao > > Cc: Ben Dooks > > Cc: David Woodhouse > > Signed-off-by: Marc Zyngier > > Acked-by: Artem Bityutskiy Acked-by: Jean-Christophe PLAGNIOL-VILLARD Best Regards, J. From mboxrd@z Thu Jan 1 00:00:00 1970 From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD) Date: Thu, 19 May 2011 19:37:10 +0200 Subject: [PATCH v6 8/8] MTD: physmap: let set_vpp() pass a platform_device instead of a map_info In-Reply-To: <1305803858.2630.67.camel@localhost> References: <1305637877-24436-1-git-send-email-marc.zyngier@arm.com> <1305637877-24436-9-git-send-email-marc.zyngier@arm.com> <1305803858.2630.67.camel@localhost> Message-ID: <20110519173710.GR15292@game.jcrosoft.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 14:17 Thu 19 May , Artem Bityutskiy wrote: > On Tue, 2011-05-17 at 14:11 +0100, Marc Zyngier wrote: > > The set_vpp() method provided by physmap passes a map_info back to > > the platform code, which has little relevance as far as the platform > > is concerned (this parameter is completely unused). > > > > Instead, pass the platform_device, which can be used in the pismo > > driver to retrieve some important information in a nicer way, instead > > of the hack that was in place. > > > > The empty set_vpp function in board-at572d940hf_ek.c is left untouched, > > as the board/SoC is scheduled for removal. > > > > Cc: Andrew Victor > > Cc: Nicolas Ferre > > Cc: Jean-Christophe Plagniol-Villard > > Cc: Russell King > > Cc: Philipp Zabel > > Cc: Eric Miao > > Cc: Ben Dooks > > Cc: David Woodhouse > > Signed-off-by: Marc Zyngier > > Acked-by: Artem Bityutskiy Acked-by: Jean-Christophe PLAGNIOL-VILLARD Best Regards, J.