All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@redhat.com>
To: Yongqiang Yang <xiaoqiangnk@gmail.com>
Cc: josef@redhat.com, sandeen@redhat.com, xfs@oss.sgi.com,
	linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2] xfstests:Make 225 compare map and fiemap at each block.
Date: Thu, 19 May 2011 14:19:16 -0400	[thread overview]
Message-ID: <20110519181916.GC18123@dhcp231-156.rdu.redhat.com> (raw)
In-Reply-To: <1305789665-32743-1-git-send-email-xiaoqiangnk@gmail.com>

On Thu, May 19, 2011 at 03:21:05PM +0800, Yongqiang Yang wrote:
> Due to my carelessness, I induced a ugly patch to ext4's fiemap, but
> 225 could not find it.  So I looked into the 225 and could not figure out
> logic in compare_map_and_fiemap(), which seemed to mix extents with
> blocks.  Then I made 225 compare map and fiemap at each block, the new
> 225 can find another bug in ext4 with 1k block.
> 
> The new 225 works well on ext3, ext4 and xfs with both 1K and 4K block.
> 
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>

Reviewed-by: Josef Bacik <josef@redhat.com>

Thanks,

Josef

WARNING: multiple messages have this Message-ID (diff)
From: Josef Bacik <josef@redhat.com>
To: Yongqiang Yang <xiaoqiangnk@gmail.com>
Cc: sandeen@redhat.com, linux-ext4@vger.kernel.org, josef@redhat.com,
	xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfstests:Make 225 compare map and fiemap at each block.
Date: Thu, 19 May 2011 14:19:16 -0400	[thread overview]
Message-ID: <20110519181916.GC18123@dhcp231-156.rdu.redhat.com> (raw)
In-Reply-To: <1305789665-32743-1-git-send-email-xiaoqiangnk@gmail.com>

On Thu, May 19, 2011 at 03:21:05PM +0800, Yongqiang Yang wrote:
> Due to my carelessness, I induced a ugly patch to ext4's fiemap, but
> 225 could not find it.  So I looked into the 225 and could not figure out
> logic in compare_map_and_fiemap(), which seemed to mix extents with
> blocks.  Then I made 225 compare map and fiemap at each block, the new
> 225 can find another bug in ext4 with 1k block.
> 
> The new 225 works well on ext3, ext4 and xfs with both 1K and 4K block.
> 
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>

Reviewed-by: Josef Bacik <josef@redhat.com>

Thanks,

Josef

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2011-05-19 18:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-19  7:21 [PATCH v2] xfstests:Make 225 compare map and fiemap at each block Yongqiang Yang
2011-05-19  7:21 ` Yongqiang Yang
2011-05-19  7:24 ` Yongqiang Yang
2011-05-19  7:24   ` Yongqiang Yang
2011-05-19 11:12 ` Dave Chinner
2011-05-19 11:12   ` Dave Chinner
2011-05-22 12:38   ` Yongqiang Yang
2011-05-22 12:38     ` Yongqiang Yang
2011-05-19 18:19 ` Josef Bacik [this message]
2011-05-19 18:19   ` Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110519181916.GC18123@dhcp231-156.rdu.redhat.com \
    --to=josef@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=xfs@oss.sgi.com \
    --cc=xiaoqiangnk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.