From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934438Ab1ESTbg (ORCPT ); Thu, 19 May 2011 15:31:36 -0400 Received: from mail-px0-f173.google.com ([209.85.212.173]:39817 "EHLO mail-px0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933808Ab1ESTbf (ORCPT ); Thu, 19 May 2011 15:31:35 -0400 Date: Thu, 19 May 2011 13:31:32 -0600 From: Grant Likely To: Axel Lin Cc: linux-kernel@vger.kernel.org, Wan ZongShun , spi-devel-general@lists.sourceforge.net Subject: Re: [PATCH 1/2] spi: spi_nuc900: Use spi_bitbang_stop instead of spi_unregister_master in nuc900_spi_remove Message-ID: <20110519193132.GQ5109@ponder.secretlab.ca> References: <1305416008.24670.1.camel@phoenix> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1305416008.24670.1.camel@phoenix> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 15, 2011 at 07:33:28AM +0800, Axel Lin wrote: > Calling spi_bitbang_stop() will also destroy bitbang->workqueue, > which is created by calling spi_bitbang_start() in nuc900_spi_probe(). > > Signed-off-by: Axel Lin Applied, thanks. g. > --- > drivers/spi/spi_nuc900.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/spi/spi_nuc900.c b/drivers/spi/spi_nuc900.c > index d5be18b..3cd15f6 100644 > --- a/drivers/spi/spi_nuc900.c > +++ b/drivers/spi/spi_nuc900.c > @@ -463,7 +463,7 @@ static int __devexit nuc900_spi_remove(struct platform_device *dev) > > platform_set_drvdata(dev, NULL); > > - spi_unregister_master(hw->master); > + spi_bitbang_stop(&hw->bitbang); > > clk_disable(hw->clk); > clk_put(hw->clk); > -- > 1.7.1 > > >