All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawn.guo@freescale.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawn.guo@linaro.org>, <linux-kernel@vger.kernel.org>,
	<grant.likely@secretlab.ca>, <linus.walleij@linaro.org>,
	<kernel@pengutronix.de>, <linux-arm-kernel@lists.infradead.org>,
	<patches@linaro.org>
Subject: Re: [PATCH 0/4] add gpio driver gpio-mxs
Date: Fri, 20 May 2011 18:24:11 +0800	[thread overview]
Message-ID: <20110520102410.GD27251@S2100-06.ap.freescale.net> (raw)
In-Reply-To: <20110520100242.GA10403@pengutronix.de>

On Fri, May 20, 2011 at 12:02:42PM +0200, Sascha Hauer wrote:
> Hi Shawn,
> 
Hi Sascha,

> On Fri, May 20, 2011 at 05:51:25PM +0800, Shawn Guo wrote:
> > The patch set is to move Freescale MXS gpio driver from mach-mxs
> > into drivers/gpio.  Different from u300 gpio driver that all gpio
> > ports are registered as one device, gpio-mxs expects every single
> > port is a gpio device.
> > 
> > The first 3 patches are just to ease review and can be squashed into
> > the last one.
> > 
> > Shawn Guo (4):
> >       gpio: gpio-mxs: add file gpio-mxs.c
> >       gpio: gpio-mxs: drop mach-specific accessors
> >       gpio: gpio-mxs: remove gpio port definition and registration
> >       gpio: gpio-mxs: add gpio driver for Freescale MXS architecture
> 
> Your series should be bisectible. So please either:
> 
> - Add the driver the way you want it (no need to modify a new file in
>   four steps)

As I said above, I split it into 4 patches just to ease the review,
and they can be squashed into one when applying.

> - atomically switch to the new driver
> - remove old driver
> 
These two steps happened in the patch set '[PATCH 0/3] remove mach-mxs
gpio driver'.  The patch order should be reworked though.

BTW, are you looking at moving plat-mxc/gpio.c, or I can give a hand
there?

-- 
Regards,
Shawn


  reply	other threads:[~2011-05-20 10:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-20  9:51 Shawn Guo
2011-05-20  9:51 ` Shawn Guo
2011-05-20  9:51 ` [PATCH 1/4] gpio: gpio-mxs: add file gpio-mxs.c Shawn Guo
2011-05-20  9:51   ` Shawn Guo
2011-05-20  9:51 ` [PATCH 2/4] gpio: gpio-mxs: drop mach-specific accessors Shawn Guo
2011-05-20  9:51   ` Shawn Guo
2011-05-20  9:51 ` [PATCH 3/4] gpio: gpio-mxs: remove gpio port definition and registration Shawn Guo
2011-05-20  9:51   ` Shawn Guo
2011-05-20  9:51 ` [PATCH 4/4] gpio: gpio-mxs: add gpio driver for Freescale MXS architecture Shawn Guo
2011-05-20  9:51   ` Shawn Guo
2011-05-20 11:24   ` Sascha Hauer
2011-05-20 11:24     ` Sascha Hauer
2011-05-20 14:31     ` Shawn Guo
2011-05-20 14:31       ` Shawn Guo
2011-05-20 10:02 ` [PATCH 0/4] add gpio driver gpio-mxs Sascha Hauer
2011-05-20 10:02   ` Sascha Hauer
2011-05-20 10:24   ` Shawn Guo [this message]
2011-05-20 11:25     ` Sascha Hauer
2011-05-20 11:25       ` Sascha Hauer
2011-05-27  3:15     ` Grant Likely
2011-05-27  3:15       ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110520102410.GD27251@S2100-06.ap.freescale.net \
    --to=shawn.guo@freescale.com \
    --cc=grant.likely@secretlab.ca \
    --cc=kernel@pengutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawn.guo@linaro.org \
    --subject='Re: [PATCH 0/4] add gpio driver gpio-mxs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.