All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: linux-next: build failure in Linus' tree
Date: Fri, 20 May 2011 11:15:16 +1000	[thread overview]
Message-ID: <20110520111516.784c0c9c.sfr@canb.auug.org.au> (raw)

Hi Linus,

With just Linus' tree, today's linux-next build (powerpc ppc64_defconfig)
failed like this:

In file included from arch/powerpc/mm/fault.c:18:
include/linux/signal.h:239: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:239: error: its scope is only this definition or declaration, which is probably not what you want
include/linux/signal.h:240: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:241: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:250: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:254: error: 'struct task_struct' declared inside parameter list
cc1: warnings being treated as errors

and so on ...

reverting commit e66eed651fd1 ("list: remove prefetching from regular
list iterators").  This is, of course, why we like to put stuff into
linux-next before it goes into your tree :-)

I have applied this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 20 May 2011 11:11:53 +1000
Subject: [PATCH] signal.h need a definition of struct task_struct

fixes these build errors on powerpc:

In file included from arch/powerpc/mm/fault.c:18:
include/linux/signal.h:239: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:239: error: its scope is only this definition or declaration, which is probably not what you want
include/linux/signal.h:240: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:241: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:250: error: 'struct task_struct' declared inside parameter list
include/linux/signal.h:254: error: 'struct task_struct' declared inside parameter list
cc1: warnings being treated as errors

Exposed by commit e66eed651fd1 ("list: remove prefetching from regular
list iterators").

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/signal.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/linux/signal.h b/include/linux/signal.h
index fcd2b14..29a68ac 100644
--- a/include/linux/signal.h
+++ b/include/linux/signal.h
@@ -7,6 +7,8 @@
 #ifdef __KERNEL__
 #include <linux/list.h>
 
+struct task_struct;
+
 /* for sysctl */
 extern int print_fatal_signals;
 /*
-- 
1.7.5.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

             reply	other threads:[~2011-05-20  1:15 UTC|newest]

Thread overview: 98+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-20  1:15 Stephen Rothwell [this message]
2011-05-20  1:19 ` linux-next: build failure in Linus' tree Linus Torvalds
  -- strict thread matches above, loose matches on Subject: below --
2022-03-27 22:01 Stephen Rothwell
2022-03-27 22:01 ` Stephen Rothwell
2022-03-27 22:23 ` Linus Torvalds
2022-03-27 22:23   ` Linus Torvalds
2022-03-27 22:31   ` Linus Torvalds
2022-03-27 22:31     ` Linus Torvalds
2022-03-27 23:33   ` Stephen Rothwell
2022-03-27 23:33     ` Stephen Rothwell
2021-11-05  4:54 Stephen Rothwell
2021-11-05  9:25 ` Suzuki K Poulose
2021-11-05  4:49 Stephen Rothwell
2021-09-07  1:02 Stephen Rothwell
2021-09-06  5:57 Stephen Rothwell
2021-07-14 23:50 Stephen Rothwell
2021-07-20  6:45 ` Stephen Rothwell
2021-07-20 12:11   ` Jakub Kicinski
2021-07-22 23:04     ` Stephen Rothwell
2020-11-23  7:40 Stephen Rothwell
2020-11-23  7:40 ` Stephen Rothwell
2020-11-23 23:39 ` Michael Ellerman
2020-11-23 23:39   ` Michael Ellerman
2020-11-24  0:23   ` Daniel Axtens
2020-11-25  2:47     ` Michael Ellerman
2020-06-21  2:05 Stephen Rothwell
2020-04-20 11:46 linux-next: build failure in Linus tree Stephen Rothwell
2020-04-28  8:48 ` Stephen Rothwell
2020-05-18 22:20 ` Stephen Rothwell
2020-04-05  1:22 linux-next: build failure in Linus' tree Stephen Rothwell
2020-04-05  1:27 ` Stephen Rothwell
2020-02-09 21:08 Stephen Rothwell
2020-02-09 21:24 ` Linus Torvalds
2020-02-09 22:57   ` Marc Zyngier
2020-02-09 23:48     ` Linus Torvalds
2020-02-10  2:00     ` Zenghui Yu
2018-10-28 22:45 Stephen Rothwell
2018-10-28 22:35 Stephen Rothwell
2018-10-28 22:45 ` Linus Torvalds
2018-10-29  1:38   ` Hangbin Liu
2018-10-29  2:17   ` David Miller
2018-06-12  2:26 Stephen Rothwell
2018-06-18  3:50 ` Stephen Rothwell
2018-02-04 22:28 Stephen Rothwell
2017-09-17 23:34 Stephen Rothwell
2016-03-27  6:06 Stephen Rothwell
2016-03-28 20:44 ` Arnaldo Carvalho de Melo
2014-11-03  4:09 Stephen Rothwell
2014-11-03  4:09 ` Stephen Rothwell
2014-11-03  4:16 ` David Miller
2012-07-27  0:15 Stephen Rothwell
2012-07-27  0:23 ` Stephen Rothwell
2012-07-27  1:04 ` Linus Torvalds
2012-06-14  1:47 Stephen Rothwell
2012-06-14  3:06 ` Paul Mundt
2012-06-14  3:40   ` Paul Mundt
2012-06-15  0:14     ` Stephen Rothwell
2012-06-15  0:56       ` Paul Mundt
2012-06-17 23:38         ` Benjamin Herrenschmidt
2012-06-18  4:58           ` Paul Mundt
2012-06-15  9:23       ` Sedat Dilek
2012-06-15 10:15         ` Sedat Dilek
2012-06-15  8:46     ` Richard W.M. Jones
2012-06-15 11:38     ` Arnd Bergmann
2012-05-14  0:50 Stephen Rothwell
2012-05-14  6:57 ` Grant Likely
2012-05-14  8:32   ` Thomas Gleixner
2012-05-07  0:08 Stephen Rothwell
2012-05-07  0:10 ` Al Viro
2012-04-19  0:41 Stephen Rothwell
2012-01-24  0:51 Stephen Rothwell
2011-08-29  0:44 Stephen Rothwell
2011-08-29  0:44 ` Stephen Rothwell
2011-08-29 22:32 ` Stephen Rothwell
2011-08-29 22:32   ` Stephen Rothwell
2011-08-29 22:50   ` James Bottomley
2011-08-29 22:50     ` James Bottomley
2011-08-11  1:59 Stephen Rothwell
2011-08-11  6:43 ` Borislav Petkov
2011-05-26  1:12 Stephen Rothwell
2011-03-17 23:29 Stephen Rothwell
2011-03-17 23:35 ` Luck, Tony
2011-01-14 23:40 Stephen Rothwell
2011-01-19  3:12 ` Konrad Rzeszutek Wilk
2011-01-19  4:19   ` Stephen Rothwell
2011-01-13 23:43 Stephen Rothwell
2011-01-14  1:24 ` Linus Torvalds
2011-01-14  2:17   ` Al Viro
2010-12-21  1:01 Stephen Rothwell
2010-12-21  4:47 ` Sedat Dilek
2010-10-06  0:09 Stephen Rothwell
2010-10-06  0:09 ` Stephen Rothwell
2010-05-28  0:57 Stephen Rothwell
2010-05-28  1:09 ` Linus Torvalds
2010-05-30  0:43   ` Stephen Rothwell
2010-06-01 17:04     ` Tony Luck
2010-06-01 17:07       ` Linus Torvalds
2010-05-24  0:40 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110520111516.784c0c9c.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.