From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44960)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1QNRzu-0000Rg-8u
	for qemu-devel@nongnu.org; Fri, 20 May 2011 11:52:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hch@lst.de>) id 1QNRzt-0001gi-DF
	for qemu-devel@nongnu.org; Fri, 20 May 2011 11:52:18 -0400
Received: from verein.lst.de ([213.95.11.211]:33589 helo=newverein.lst.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1QNRzt-0001ge-8M
	for qemu-devel@nongnu.org; Fri, 20 May 2011 11:52:17 -0400
Date: Fri, 20 May 2011 17:52:16 +0200
From: Christoph Hellwig <hch@lst.de>
Message-ID: <20110520155216.GC4466@lst.de>
References: <1305630067-2119-1-git-send-email-pbonzini@redhat.com>
	<1305630067-2119-4-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1305630067-2119-4-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 03/21] scsi: introduce scsi_req_data
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On Tue, May 17, 2011 at 01:00:49PM +0200, Paolo Bonzini wrote:
> This abstracts calling the command_complete callback, reducing churn
> in the following patches.

Adding the helper sounds fine to me, but the name seems rather badly
chosen.  What about scsi_req_get_more_data or similar?  Either way
a comment above the function describing what it does would be useful,
too.