From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36631)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1QNS1Q-000156-DC
	for qemu-devel@nongnu.org; Fri, 20 May 2011 11:53:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hch@lst.de>) id 1QNS1P-0001nP-Lc
	for qemu-devel@nongnu.org; Fri, 20 May 2011 11:53:52 -0400
Received: from verein.lst.de ([213.95.11.211]:33599 helo=newverein.lst.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1QNS1P-0001nD-CE
	for qemu-devel@nongnu.org; Fri, 20 May 2011 11:53:51 -0400
Date: Fri, 20 May 2011 17:53:50 +0200
From: Christoph Hellwig <hch@lst.de>
Message-ID: <20110520155350.GD4466@lst.de>
References: <1305630067-2119-1-git-send-email-pbonzini@redhat.com>
	<1305630067-2119-5-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1305630067-2119-5-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 04/21] scsi: introduce SCSIBusOps
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

>      qbus_create_inplace(&bus->qbus, &scsi_bus_info, host, NULL);
>      bus->busnr = next_scsi_bus++;
>      bus->tcq = tcq;
>      bus->ndev = ndev;
> -    bus->complete = complete;
> +    bus->ops = *ops;

Normally bus->ops would be a pointer, so you can just assign it to
the address passed in instead of doing a copy.  Any good reason to
do it differently here?