From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47477)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1QNSIX-0006KB-Hh
	for qemu-devel@nongnu.org; Fri, 20 May 2011 12:11:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hch@lst.de>) id 1QNSIW-0004WR-Qv
	for qemu-devel@nongnu.org; Fri, 20 May 2011 12:11:33 -0400
Received: from verein.lst.de ([213.95.11.211]:42334 helo=newverein.lst.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1QNSIW-0004WN-M1
	for qemu-devel@nongnu.org; Fri, 20 May 2011 12:11:32 -0400
Date: Fri, 20 May 2011 18:11:32 +0200
From: Christoph Hellwig <hch@lst.de>
Message-ID: <20110520161132.GU4466@lst.de>
References: <1305630067-2119-1-git-send-email-pbonzini@redhat.com>
	<1305630067-2119-22-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1305630067-2119-22-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 21/21] scsi: split
	command_complete	callback in two
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

> +static void esp_command_complete(SCSIRequest *req, uint32_t arg)

Shouldn't the "arg" argument to the new ->command_complete be renamed
to something like "sense" or "status"?

> +static void esp_transfer_data(SCSIRequest *req, uint32_t arg)
> +{
> +    ESPState *s = DO_UPCAST(ESPState, busdev.qdev, req->bus->qbus.parent);
> +
> +    DPRINTF("transfer %d/%d\n", s->dma_left, s->ti_size);
> +    s->async_len = arg;
> +    s->async_buf = scsi_req_get_buf(req);
> +    if (s->dma_left) {
> +        esp_do_dma(s);
> +    } else if (s->dma_counter != 0 && s->ti_size <= 0) {
> +        /* If this was the last part of a DMA transfer then the
> +           completion interrupt is deferred to here.  */

And for transfer_data "arg" should become "len".