From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, shemminger@vyatta.com, jpirko@redhat.com
Subject: Re: [PATCH net-next-2.6] net: remove synchronize_net() from netdev_set_master()
Date: Sun, 22 May 2011 21:03:26 -0400 (EDT) [thread overview]
Message-ID: <20110522.210326.1316361026223897933.davem@davemloft.net> (raw)
In-Reply-To: <1305869860.3156.49.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 20 May 2011 07:37:40 +0200
> In the old days, we used to access dev->master in __netif_receive_skb()
> in a rcu_read_lock section.
>
> So one synchronize_net() call was needed in netdev_set_master() to make
> sure another cpu could not use old master while/after we release it.
>
> We now use netdev_rx_handler infrastructure and added one
> synchronize_net() call in bond_release()/bond_release_all()
>
> Remove the obsolete synchronize_net() from netdev_set_master() and add
> one in bridge del_nbp() after its netdev_rx_handler_unregister() call.
>
> This makes enslave -d a bit faster.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> CC: Jiri Pirko <jpirko@redhat.com>
> CC: Stephen Hemminger <shemminger@vyatta.com>
Applied.
prev parent reply other threads:[~2011-05-23 1:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 5:37 [PATCH net-next-2.6] net: remove synchronize_net() from netdev_set_master() Eric Dumazet
2011-05-23 1:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110522.210326.1316361026223897933.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.