From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH 2/5 V2] kvm tools: Add video mode to kernel initialization Date: Mon, 23 May 2011 13:30:50 +0200 Message-ID: <20110523113050.GC4042@elte.hu> References: <1306149553-26793-1-git-send-email-levinsasha928@gmail.com> <1306149553-26793-2-git-send-email-levinsasha928@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: penberg@kernel.org, john@jfloren.net, kvm@vger.kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com, prasadjoshi124@gmail.com To: Sasha Levin Return-path: Received: from mx2.mail.elte.hu ([157.181.151.9]:40624 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754086Ab1EWLa7 (ORCPT ); Mon, 23 May 2011 07:30:59 -0400 Content-Disposition: inline In-Reply-To: <1306149553-26793-2-git-send-email-levinsasha928@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: * Sasha Levin wrote: > bool kvm__load_kernel(struct kvm *kvm, const char *kernel_filename, > - const char *initrd_filename, const char *kernel_cmdline); > + const char *initrd_filename, const char *kernel_cmdline, u16 vidmode); Suggestion for future cleanup: we really want to gros a 'struct kernel_params' kind of thing which could be passed along here by address. That would make it easier to extent it with whatever may come along in the future, and would make the code look cleaner as well. Thanks, Ingo