From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
Subject: Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling
Date: Mon, 23 May 2011 18:43:25 +0200
Message-ID: <20110523164325.GF27867@amd.com>
References: <20110517143532.GA2490@fermat.math.technion.ac.il>
 <4DD2902C.9050403@redhat.com>
 <20110517181132.GA16262@fermat.math.technion.ac.il>
 <20110517184336.GA10394@amt.cnet>
 <20110517193030.GA21656@fermat.math.technion.ac.il>
 <20110517195253.GB11065@amt.cnet>
 <20110518055236.GA1230@fermat.math.technion.ac.il>
 <20110518120801.GA9176@amt.cnet>
 <20110522085732.GB1116@fermat.math.technion.ac.il>
 <4DDA81FD.5050203@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: Nadav Har'El <nyh@math.technion.ac.il>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"gleb@redhat.com" <gleb@redhat.com>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from va3ehsobe001.messaging.microsoft.com ([216.32.180.11]:12182
	"EHLO VA3EHSOBE008.bigfish.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1756556Ab1EWQnc (ORCPT
	<rfc822;kvm@vger.kernel.org>); Mon, 23 May 2011 12:43:32 -0400
Content-Disposition: inline
In-Reply-To: <4DDA81FD.5050203@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, May 23, 2011 at 11:49:17AM -0400, Avi Kivity wrote:

> Joerg, is
> 
>      if (unlikely(cpu != vcpu->cpu)) {
>          svm->asid_generation = 0;
>          mark_all_dirty(svm->vmcb);
>      }
> 
> susceptible to cpu offline/online?

I don't think so. This should be safe for cpu offline/online as long as
the cpu-number value is not reused for another physical cpu. But that
should be the case afaik.

	Joerg