From: David Miller <davem@davemloft.net>
To: mirq-linux@rere.qmqm.pl
Cc: bhutchings@solarflare.com, netdev@vger.kernel.org
Subject: Re: [PATCH] ethtool: ETHTOOL_SFEATURES: remove NETIF_F_COMPAT return
Date: Tue, 24 May 2011 15:39:30 -0400 (EDT) [thread overview]
Message-ID: <20110524.153930.610330240390616957.davem@davemloft.net> (raw)
In-Reply-To: <20110524091437.GA10779@rere.qmqm.pl>
From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: Tue, 24 May 2011 11:14:37 +0200
> On Thu, May 19, 2011 at 12:03:31PM +0200, Michał Mirosław wrote:
>> On Mon, May 16, 2011 at 02:09:58PM -0400, David Miller wrote:
>> > You guys really need to sort this out properly.
>> > Please resubmit whatever final solution is agreed upon.
>> I noticed that v2.6.39 was tagged today. We should definitely remove
>> NETIF_F_COMPAT so it won't bite us in the future. The other patch that
>> fixes ethtool_ops->set_flags compatibility is a bugfix, so it should go
>> in - if we decide that the SFEATURES compatibility should be removed
>> it won't matter.
>>
>> Ben, do you agree?
>
> Ping?
>
> http://patchwork.ozlabs.org/patch/95552/
> (this is a bugfix, so should go to stable)
>
> http://patchwork.ozlabs.org/patch/95753/
> (removes ETHTOOL_F_COMPAT; this we need to decide on)
You and Ben are still arguing over details.
I want fresh versions of these patches (yes, both of them) once
all of the issues are resolved.
next prev parent reply other threads:[~2011-05-24 19:39 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-14 1:05 [PATCH net-2.6] ethtool: Remove fallback to old ethtool operations for ETHTOOL_SFEATURES Ben Hutchings
2011-05-14 9:54 ` Michał Mirosław
2011-05-14 20:08 ` Ben Hutchings
2011-05-14 10:31 ` [PATCH] net: fix ETHTOOL_SFEATURES compatibility with old ethtool_ops.set_flags Michał Mirosław
2011-05-14 10:35 ` [PATCH net-2.6] ethtool: Remove fallback to old ethtool operations for ETHTOOL_SFEATURES Michał Mirosław
2011-05-16 2:45 ` Ben Hutchings
2011-05-16 12:13 ` Michał Mirosław
2011-05-16 13:28 ` [PATCH] ethtool: ETHTOOL_SFEATURES: remove NETIF_F_COMPAT return Michał Mirosław
2011-05-16 13:37 ` Ben Hutchings
2011-05-16 14:23 ` Michał Mirosław
2011-05-16 14:53 ` Ben Hutchings
2011-05-16 15:01 ` Michał Mirosław
2011-05-16 15:57 ` [RFC PATCH ethtool 1/3] ethtool: Regularise offload feature settings Ben Hutchings
2011-05-16 15:57 ` [RFC PATCH ethtool 2/3] ethtool: Report any consequential offload feature changes Ben Hutchings
2011-05-16 15:58 ` [RFC PATCH ethtool 3/3] ethtool: Use ETHTOOL_{G,S}FEATURES where available Ben Hutchings
2011-05-16 20:51 ` [PATCH] ethtool: ETHTOOL_SFEATURES: remove NETIF_F_COMPAT return Michał Mirosław
2011-05-16 21:08 ` Ben Hutchings
2011-05-16 21:50 ` Michał Mirosław
2011-05-16 22:09 ` Ben Hutchings
2011-05-17 8:45 ` Michał Mirosław
2011-05-17 20:33 ` [RFC PATCH ethtool] ethtool: merge ETHTOOL_[GS]FEATURES support to -k/-K modes Michał Mirosław
2011-05-18 19:02 ` [PATCH] ethtool: ETHTOOL_SFEATURES: remove NETIF_F_COMPAT return Ben Hutchings
2011-05-19 9:18 ` Michał Mirosław
2011-05-19 13:25 ` [RFC PATCH v3 ethtool] ethtool: implement [GS]FEATURES calls Michał Mirosław
2011-05-16 20:54 ` [RFC PATCH ethtool] ethtool: implement G/SFEATURES calls Michał Mirosław
2011-05-16 18:09 ` [PATCH] ethtool: ETHTOOL_SFEATURES: remove NETIF_F_COMPAT return David Miller
2011-05-19 10:03 ` Michał Mirosław
2011-05-24 9:14 ` Michał Mirosław
2011-05-24 19:39 ` David Miller [this message]
2011-05-24 21:59 ` Michał Mirosław
2011-05-27 14:13 ` Ben Hutchings
2011-05-27 15:28 ` Michał Mirosław
2011-05-27 15:45 ` Ben Hutchings
2011-05-27 16:34 ` Michał Mirosław
2011-05-27 23:25 ` Ben Hutchings
2011-05-28 7:35 ` Michał Mirosław
[not found] ` <20110528073525.GA19033-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
2011-05-28 10:07 ` [Xen-devel] " Ian Campbell
[not found] ` <1306577228.23577.17.camel-ztPmHsLffjjnO4AKDKe2m+kiAK3p4hvP@public.gmane.org>
2011-05-28 17:31 ` Jesse Gross
[not found] ` <BANLkTime8PHYe+BFELt92gg7SZ91xKvAwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-29 9:38 ` Michał Mirosław
[not found] ` <20110529093849.GA5245-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
2011-05-31 18:43 ` Jesse Gross
2011-05-26 10:42 ` [RESEND PATCH net] net: fix ETHTOOL_SFEATURES compatibility with old ethtool_ops.set_flags Michał Mirosław
2011-05-26 18:14 ` David Miller
2011-05-14 10:41 ` [PATCH v2] " Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110524.153930.610330240390616957.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.