From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Roedel, Joerg" Subject: Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling Date: Tue, 24 May 2011 11:57:17 +0200 Message-ID: <20110524095717.GA13157@amd.com> References: <20110517193030.GA21656@fermat.math.technion.ac.il> <20110517195253.GB11065@amt.cnet> <20110518055236.GA1230@fermat.math.technion.ac.il> <20110518120801.GA9176@amt.cnet> <20110522085732.GB1116@fermat.math.technion.ac.il> <4DDA81FD.5050203@redhat.com> <20110523164325.GF27867@amd.com> <4DDA90AB.5010604@redhat.com> <20110524092206.GH27867@amd.com> <20110524092838.GB136@fermat.math.technion.ac.il> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Avi Kivity , Marcelo Tosatti , "kvm@vger.kernel.org" , "gleb@redhat.com" To: Nadav Har'El Return-path: Received: from db3ehsobe003.messaging.microsoft.com ([213.199.154.141]:42825 "EHLO DB3EHSOBE003.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752589Ab1EXJ5T (ORCPT ); Tue, 24 May 2011 05:57:19 -0400 Content-Disposition: inline In-Reply-To: <20110524092838.GB136@fermat.math.technion.ac.il> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, May 24, 2011 at 05:28:38AM -0400, Nadav Har'El wrote: > On Tue, May 24, 2011, Roedel, Joerg wrote about "Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling": > > Probably we should make the local_vcpu_list from vmx generic, use it > > from svm and fix it this way. > > The point is, local_vcpu_list is now gone, replaced by a loaded_vmcss_on_cpu, > and vcpu->cpu is not set to -1 for any vcpu when a CPU is offlined - also in > VMX... loaded_vmcss_on_cpu sound similar, probably this can be generalized. Is this code already upstream or is this changed with your nVMX patch-set? Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632