From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nadav Har'El" Subject: Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling Date: Tue, 24 May 2011 13:12:19 +0300 Message-ID: <20110524101219.GA3437@fermat.math.technion.ac.il> References: <20110517195253.GB11065@amt.cnet> <20110518055236.GA1230@fermat.math.technion.ac.il> <20110518120801.GA9176@amt.cnet> <20110522085732.GB1116@fermat.math.technion.ac.il> <4DDA81FD.5050203@redhat.com> <20110523164325.GF27867@amd.com> <4DDA90AB.5010604@redhat.com> <20110524092206.GH27867@amd.com> <20110524092838.GB136@fermat.math.technion.ac.il> <20110524095717.GA13157@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , Marcelo Tosatti , "kvm@vger.kernel.org" , "gleb@redhat.com" To: "Roedel, Joerg" Return-path: Received: from mailgw12.technion.ac.il ([132.68.225.12]:31018 "EHLO mailgw12.technion.ac.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756491Ab1EXKMW (ORCPT ); Tue, 24 May 2011 06:12:22 -0400 Content-Disposition: inline In-Reply-To: <20110524095717.GA13157@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, May 24, 2011, Roedel, Joerg wrote about "Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling": > loaded_vmcss_on_cpu sound similar, probably this can be generalized. I don't think so - now that a VCPU may have several VMCSs (L1, L2), each of those may be loaded on a different cpu so we have a list of VMCSs (the new loaded_vmcs structure), not vcpus. When we offline a CPU, we recall all VMCSs loaded on it from this list, and clear them; We mark cpu=-1 for each of those vmcs, but vcpu->cpu remains untouched (and not set to -1) for all the vcpus. > Is this code already upstream or is this changed with your nVMX patch-set? Avi asked me to send the patch that does this *before* nvmx. But he did not yet merge it. -- Nadav Har'El | Tuesday, May 24 2011, 20 Iyyar 5771 nyh@math.technion.ac.il |----------------------------------------- Phone +972-523-790466, ICQ 13349191 |If you notice this notice, you'll notice http://nadav.harel.org.il |it's not worth noticing but is noticable.