From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nadav Har'El" Subject: Re: [PATCH 08/31] nVMX: Fix local_vcpus_link handling Date: Tue, 24 May 2011 14:59:03 +0300 Message-ID: <20110524115903.GA6627@fermat.math.technion.ac.il> References: <20110523185104.GA26899@fermat.math.technion.ac.il> <625BA99ED14B2D499DC4E29D8138F1505C9BEF07A9@shsmsx502.ccr.corp.intel.com> <20110524075656.GA26588@fermat.math.technion.ac.il> <625BA99ED14B2D499DC4E29D8138F1505C9BFA33FE@shsmsx502.ccr.corp.intel.com> <4DDB9105.9050900@redhat.com> <625BA99ED14B2D499DC4E29D8138F1505C9BFA34F7@shsmsx502.ccr.corp.intel.com> <4DDB9616.9010801@redhat.com> <625BA99ED14B2D499DC4E29D8138F1505C9BFA34FE@shsmsx502.ccr.corp.intel.com> <4DDB9856.9060206@redhat.com> <625BA99ED14B2D499DC4E29D8138F1505C9BFA3507@shsmsx502.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , Marcelo Tosatti , "kvm@vger.kernel.org" , "gleb@redhat.com" , "Roedel, Joerg" To: "Tian, Kevin" Return-path: Received: from mailgw12.technion.ac.il ([132.68.225.12]:49176 "EHLO mailgw12.technion.ac.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755041Ab1EXL7K (ORCPT ); Tue, 24 May 2011 07:59:10 -0400 Content-Disposition: inline In-Reply-To: <625BA99ED14B2D499DC4E29D8138F1505C9BFA3507@shsmsx502.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, May 24, 2011, Tian, Kevin wrote about "RE: [PATCH 08/31] nVMX: Fix local_vcpus_link handling": > I'm fine with this patch except that Nadav needs to clarify the comment > in __loaded_vmcs_clear (regarding to 'cpu migration' and 'cpu offline' part > which I replied in another mail) I added a single letter, "v", to my comment ;-) Please note that the same code existed previously, and didn't have any comment. If you find this short comment more confusing (or wrong) than helpful, then I can just remove it. Avi, I'll send a new version of patch 1 in a few minutes, in a new thread this time ;-) Please let me know when (or if) you are prepared to apply the rest of the patches, so I can send a new version, rebased to the current trunk and with all the fixes people asked for in the last few days. -- Nadav Har'El | Tuesday, May 24 2011, 20 Iyyar 5771 nyh@math.technion.ac.il |----------------------------------------- Phone +972-523-790466, ICQ 13349191 |Ms Piggy's last words: "I'm pink, http://nadav.harel.org.il |therefore I'm ham."