From: Grant Likely <grant.likely@secretlab.ca>
To: Joe Perches <joe@perches.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH] gpio: Convert gpio_is_valid to return bool
Date: Thu, 26 May 2011 21:02:56 -0600 [thread overview]
Message-ID: <20110527030256.GF5032@ponder.secretlab.ca> (raw)
In-Reply-To: <1305069787.19586.141.camel@Joe-Laptop>
On Tue, May 10, 2011 at 04:23:07PM -0700, Joe Perches wrote:
> Make the code a bit more readable.
>
> Instead of casting an int to an unsigned then comparing to
> MAX_NR_GPIOS, add a >= 0 test and let the compiler optimizer
> do the conversion to unsigned.
>
> The generated code should be the same.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied, thanks.
g.
next prev parent reply other threads:[~2011-05-27 3:03 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 19:16 [PATCH 1/4] drivers: create a pinmux subsystem Linus Walleij
2011-05-02 19:16 ` Linus Walleij
2011-05-02 19:37 ` Joe Perches
2011-05-02 19:37 ` Joe Perches
2011-05-10 22:18 ` Linus Walleij
2011-05-10 22:18 ` Linus Walleij
2011-05-10 22:37 ` Joe Perches
2011-05-10 22:37 ` Joe Perches
2011-05-10 22:52 ` Linus Walleij
2011-05-10 22:52 ` Linus Walleij
2011-05-10 23:23 ` [PATCH] gpio: Convert gpio_is_valid to return bool Joe Perches
2011-05-10 23:42 ` Linus Walleij
2011-05-27 3:02 ` Grant Likely [this message]
2011-05-10 22:40 ` [PATCH 1/4] drivers: create a pinmux subsystem Mark Brown
2011-05-10 22:40 ` Mark Brown
[not found] ` <1304363786-30376-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
2011-05-02 20:52 ` Stephen Warren
2011-05-02 20:52 ` Stephen Warren
2011-05-02 20:52 ` Stephen Warren
2011-05-03 1:45 ` Ben Nizette
2011-05-03 1:45 ` Ben Nizette
2011-05-03 1:45 ` Ben Nizette
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF0497F1B201-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-05-02 21:30 ` Colin Cross
2011-05-02 21:30 ` Colin Cross
2011-05-02 21:30 ` Colin Cross
2011-05-04 9:22 ` Tony Lindgren
2011-05-04 9:22 ` Tony Lindgren
2011-05-04 9:22 ` Tony Lindgren
[not found] ` <20110504092219.GW2092-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2011-05-07 19:06 ` Mike Rapoport
2011-05-07 19:06 ` Mike Rapoport
2011-05-07 19:06 ` Mike Rapoport
[not found] ` <BANLkTin9-aKZjEGdBeZqDwHwADXCYERErg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-09 15:25 ` Tony Lindgren
2011-05-09 15:25 ` Tony Lindgren
2011-05-09 15:25 ` Tony Lindgren
2011-05-10 22:46 ` Linus Walleij
2011-05-10 22:46 ` Linus Walleij
2011-05-10 22:46 ` Linus Walleij
2011-05-03 1:47 ` Ben Nizette
2011-05-03 1:47 ` Ben Nizette
2011-05-04 9:16 ` Tony Lindgren
2011-05-04 9:16 ` Tony Lindgren
2011-05-07 19:10 ` Mike Rapoport
2011-05-07 19:10 ` Mike Rapoport
2011-05-09 15:46 ` Tony Lindgren
2011-05-09 15:46 ` Tony Lindgren
2011-05-04 22:48 ` Rohit Vaswani
2011-05-05 18:16 ` Rohit Vaswani
2011-05-05 18:16 ` Rohit Vaswani
2011-05-07 20:09 ` Greg KH
2011-05-07 20:09 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110527030256.GF5032@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=arnd@arndb.de \
--cc=joe@perches.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.