From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] ARM: SAMSUNG: serial: Fix on handling of one clock source for UART Date: Sat, 28 May 2011 17:39:04 +0800 Message-ID: <20110528093904.GC21388@kroah.com> References: <1306548243-2526-1-git-send-email-kgene.kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from out3.smtp.messagingengine.com ([66.111.4.27]:39776 "EHLO out3.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751879Ab1E1JjG (ORCPT ); Sat, 28 May 2011 05:39:06 -0400 Content-Disposition: inline In-Reply-To: <1306548243-2526-1-git-send-email-kgene.kim@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Kukjin Kim Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Boojin Kim On Fri, May 27, 2011 at 07:04:03PM -0700, Kukjin Kim wrote: > From: Boojin Kim > > This patch fixes the way of comparison for handling of two or more > clock sources for UART. > > For example, if just only one clock source is defined even though > there are two clock sources for UART, the serial driver does not > set proper clock up. Of course, it is problem. > > So this patch changes the condition of comparison to avoid useless > setup clock and adds a flag 'NO_NEED_CHECK_CLKSRC' which means > selection of source clock is not required. > > In addition, since the Exynos4210 has only one clock source for UART > this patch adds the flag into its common_init_uarts(). > > Signed-off-by: Boojin Kim > Cc: Greg Kroah-Hartman > Signed-off-by: Kukjin Kim > --- > arch/arm/mach-exynos4/init.c | 1 + > arch/arm/plat-samsung/include/plat/regs-serial.h | 2 ++ > drivers/tty/serial/s5pv210.c | 4 ++-- > 3 files changed, 5 insertions(+), 2 deletions(-) Is this needed in older kernels as well (like .39)? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: greg@kroah.com (Greg KH) Date: Sat, 28 May 2011 17:39:04 +0800 Subject: [PATCH] ARM: SAMSUNG: serial: Fix on handling of one clock source for UART In-Reply-To: <1306548243-2526-1-git-send-email-kgene.kim@samsung.com> References: <1306548243-2526-1-git-send-email-kgene.kim@samsung.com> Message-ID: <20110528093904.GC21388@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, May 27, 2011 at 07:04:03PM -0700, Kukjin Kim wrote: > From: Boojin Kim > > This patch fixes the way of comparison for handling of two or more > clock sources for UART. > > For example, if just only one clock source is defined even though > there are two clock sources for UART, the serial driver does not > set proper clock up. Of course, it is problem. > > So this patch changes the condition of comparison to avoid useless > setup clock and adds a flag 'NO_NEED_CHECK_CLKSRC' which means > selection of source clock is not required. > > In addition, since the Exynos4210 has only one clock source for UART > this patch adds the flag into its common_init_uarts(). > > Signed-off-by: Boojin Kim > Cc: Greg Kroah-Hartman > Signed-off-by: Kukjin Kim > --- > arch/arm/mach-exynos4/init.c | 1 + > arch/arm/plat-samsung/include/plat/regs-serial.h | 2 ++ > drivers/tty/serial/s5pv210.c | 4 ++-- > 3 files changed, 5 insertions(+), 2 deletions(-) Is this needed in older kernels as well (like .39)? thanks, greg k-h